Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace of ::Concerns #33

Closed
kohtaro24 opened this issue Jan 12, 2018 · 1 comment
Closed

namespace of ::Concerns #33

kohtaro24 opened this issue Jan 12, 2018 · 1 comment

Comments

@kohtaro24
Copy link
Contributor

kohtaro24 commented Jan 12, 2018

about lib/querly/concerns/backtrace_formatter.rb

Concerns is defined in the top level namespace, it may conflict to another Concerns module defined on the application layer.

I propose the following.

before

module Concerns
  module BacktraceFormatter
    def format_backtrace(backtrace, indent: 2)
      backtrace.map {|x| " "*indent + x }.join("\n")
    end
  end
end

after

module Querly
  module Concerns
    module BacktraceFormatter
      def format_backtrace(backtrace, indent: 2)
        backtrace.map {|x| " "*indent + x }.join("\n")
      end
    end
  end
end
@soutaro
Copy link
Owner

soutaro commented Jan 12, 2018

Merged #34 .

@soutaro soutaro closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants