Revert "set engines" change #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change caused projects to break, as it probably should be done as part of a major release instead.
|
Fine to me, seems legit! |
Ethan-Arrowood
approved these changes
Jan 26, 2023
trevor-scheer
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 26, 2023
Original issue resolved via southpolesteve/node-abort-controller#40 and breaking change undone as of `v3.1.1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #39
Hey @southpolesteve @Cadienvan @Ethan-Arrowood, the changes done in #38 ended up having some side effects which caused many projects to break on their install step. This change probably should be done as part of a major release instead.
This PR reverts that change so we can avoid the big impact it might have for projects that have
node-abort-controlleras a transitive dependency.