New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set two variable files from site.yml #47

Merged
merged 5 commits into from Sep 30, 2013

Conversation

Projects
None yet
3 participants
@gregkare
Contributor

gregkare commented Sep 27, 2013

That way we can override all the config from a central location. The
user.yml file overrides defaults.yml. user.yml was added to
.gitignore in order to allow a user to change it without having to worry
about merges. It's easy to do a diff to see what changed between the defaults
and your own settings.

Needs documentation, this is just a proposal.

Refs #39

@al3x

This comment has been minimized.

Show comment
Hide comment
@al3x

al3x Sep 27, 2013

Contributor

Love it, although we should probably do away with the vars files inside the respective roles so there aren't three different places that a variable could be set.

Also, any variable that has a TODO in it should probably not live in defaults.yml, lest it accidentally be applied to a template at runtime. If a variable requires user modification, it should live in user.yml.

Fantastic work, thanks so much @gkarekinian!

Contributor

al3x commented Sep 27, 2013

Love it, although we should probably do away with the vars files inside the respective roles so there aren't three different places that a variable could be set.

Also, any variable that has a TODO in it should probably not live in defaults.yml, lest it accidentally be applied to a template at runtime. If a variable requires user modification, it should live in user.yml.

Fantastic work, thanks so much @gkarekinian!

@lukecyca

This comment has been minimized.

Show comment
Hide comment
@lukecyca

lukecyca Sep 28, 2013

Contributor

Looks great. I would also add that we should be consistent with namespacing the variables since they're now all swimming in the same file. Almost all start with the name of the role in which they are used, but a few don't: key_* should be come openvpn_key_*, for example.

Contributor

lukecyca commented Sep 28, 2013

Looks great. I would also add that we should be consistent with namespacing the variables since they're now all swimming in the same file. Almost all start with the name of the role in which they are used, but a few don't: key_* should be come openvpn_key_*, for example.

gregkare added some commits Sep 27, 2013

Set two variable files from site.yml
That way we can override all the config from a central location. The
`user.yml` file overrides `defaults.yml`. `user.yml` was added to
`.gitignore` in order to allow a user to change it without having to
worry about merges. It's easy to do a diff to see what changed between
the defaults and your own settings.

Needs documentation, this is just a proposal.

Refs #39
Comment defaults
That way the default values will not be applied by mistake. The user
needs to uncomment the lines from `vars/users.yml` and set them.

Also renamed openvpn variables.

Refs #39
Add extra comment to sections
That way it's more convenient to uncomment an entire paragraph.

al3x added a commit that referenced this pull request Sep 30, 2013

Merge pull request #47 from greenalto/global_config
Set two variable files from site.yml

@al3x al3x merged commit 4b07b21 into sovereign:master Sep 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment