Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix rtm #3

Merged
merged 3 commits into from Feb 7, 2015

Conversation

Projects
None yet
2 participants
@sue445
Copy link
Contributor

commented Dec 20, 2014

  • Bugfixes when using rtm
  • tiny refactoring

sue445 added some commits Dec 20, 2014

Bugfix: wrong converted query
irb(main):003:0> params = {token: "aaa", "channel" => "#general"}
=> {:token=>"aaa", "channel"=>"#general"}

irb(main):004:0> URI.encode_www_form([params])
=> "%7B%3Atoken%3D%3E%22aaa%22%2C+%22channel%22%3D%3E%22%23general%22%7D"

irb(main):005:0> URI.encode_www_form(params)
=> "token=aaa&channel=%23general"
Bugfix: double espaced channel hash
%25general -> %2523general

%25general -> #general -> %25general
@@ -93,7 +91,7 @@ def response_check(res)
end

def get_request(params)
query = URI.encode_www_form([params])

This comment has been minimized.

Copy link
@sue445

sue445 Dec 20, 2014

Author Contributor

example

irb(main):003:0> params = {token: "aaa", "channel" => "#general"}
=> {:token=>"aaa", "channel"=>"#general"}

irb(main):004:0> URI.encode_www_form([params])
=> "%7B%3Atoken%3D%3E%22aaa%22%2C+%22channel%22%3D%3E%22%23general%22%7D"

irb(main):005:0> URI.encode_www_form(params)
=> "token=aaa&channel=%23general"
@sowawa

This comment has been minimized.

Copy link
Owner

commented Feb 7, 2015

Thanks 😃

sowawa added a commit that referenced this pull request Feb 7, 2015

@sowawa sowawa merged commit 19aab86 into sowawa:master Feb 7, 2015

@sowawa

This comment has been minimized.

Copy link
Owner

commented Feb 7, 2015

I'm sorry to be late

@sue445 sue445 deleted the sue445:feature/bugfix_rtm branch Feb 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.