Replaced setup.py with setup.cfg + pyproject.toml

[KOLANICH]

In fact setup.py can be removed, but it should be a separate commit

[soxofaan]

I'm not that familiar with pyproject.toml yet, but what is that setuptools_scm[toml]>=3.4.3 for? It's not listed at https://packaging.python.org/tutorials/packaging-projects/#creating-pyproject-toml

[KOLANICH]

It is needed to fetch version from git tags. The version restriction and toml extra is because we configure it via pyproject.toml (every tool has to read pyproject.toml itself).

[soxofaan]

In fact setup.py can be removed, but it should be a separate commit

why should it be in a separate commit?

An do you mean just a separate git commit? Or does there also have to be a build/release in between?

[KOLANICH]

why should it be in a separate commit?

It is a breaking change. Versions of pip before the one that has landed this year (it was I who has fixed that bug) cannot do editable installs on setup.py-less projects (but regular ones work for pretty long time). Having it in a separate commit allows to easily undo that commit (first git format-patch, then patch) for people stuck with obsolete versions of pip.

Or does there also have to be a build/release in between?

I meant a git commit, but it is usually good to introduce separate releases for breaking changes.