From 1103da88ae9fe723a4cacb5ac11e240a4a25797b Mon Sep 17 00:00:00 2001 From: Simon Oxtoby Date: Thu, 9 Nov 2023 14:30:26 +1000 Subject: [PATCH] getObservableProperty doesn't return properties from Object.prototype --- packages/event-reduce-react/package.json | 2 +- packages/event-reduce/package.json | 2 +- packages/event-reduce/src/models.ts | 5 ++++- tsconfig.base.json | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/event-reduce-react/package.json b/packages/event-reduce-react/package.json index bd143f2..809731c 100644 --- a/packages/event-reduce-react/package.json +++ b/packages/event-reduce-react/package.json @@ -1,7 +1,7 @@ { "name": "event-reduce-react", "description": "React integration for event-reduce: state management based on reducing observable events into state", - "version": "0.5.3", + "version": "0.5.4", "author": "Simon Oxtoby", "homepage": "https://github.com/soxtoby/event-reduce", "repository": { diff --git a/packages/event-reduce/package.json b/packages/event-reduce/package.json index 07b0338..5518fc3 100644 --- a/packages/event-reduce/package.json +++ b/packages/event-reduce/package.json @@ -1,7 +1,7 @@ { "name": "event-reduce", "description": "State management based on reducing observable events into state", - "version": "0.5.3", + "version": "0.5.4", "author": "Simon Oxtoby", "homepage": "https://github.com/soxtoby/event-reduce", "repository": { diff --git a/packages/event-reduce/src/models.ts b/packages/event-reduce/src/models.ts index b192b52..2ebe3cb 100644 --- a/packages/event-reduce/src/models.ts +++ b/packages/event-reduce/src/models.ts @@ -138,7 +138,10 @@ export function getObservableValues(instance: any): { [property: string]: Observ } export function getObservableProperty(prototype: any, key: string) { - return (getObservableProperties(prototype) || {})[key]; + let observableProperties = getObservableProperties(prototype) || {}; + return Object.hasOwn(observableProperties, key) + ? observableProperties[key] + : undefined; } function getOrAddObservableProperties(prototype: any) { diff --git a/tsconfig.base.json b/tsconfig.base.json index d915fc7..64d106f 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -2,7 +2,7 @@ "compilerOptions": { "target": "es6", "module": "commonjs", - "lib": ["es2017", "dom"], + "lib": ["ES2022", "dom"], "jsx": "react", "strict": true, "noImplicitOverride": true,