This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dhakehurst
commented
Sep 28, 2020
- progress on 3D
- skybox
- terrain (could do with more work)
- text3D (needs more work)
- Camera Movement functions and switch to "left hand rule" for 3D axis (openGL standard)
- 3D mesh builder uses indices
- Other
- add facility to switch on logging to Korge
- arg to allow Korge to run without blocking thread
- other mods to enable skybox
…ext3D # Conflicts: # korge/src/commonMain/kotlin/com/soywiz/korge3d/RenderContext3D.kt # korgw/src/commonMain/kotlin/com/soywiz/korag/AG.kt
…ext3D # Conflicts: # korge/src/commonMain/kotlin/com/soywiz/korge3d/RenderContext3D.kt # korgw/src/commonMain/kotlin/com/soywiz/korag/AG.kt
…ext3D # Conflicts: # korge/src/commonMain/kotlin/com/soywiz/korge/Korge.kt # korge/src/commonMain/kotlin/com/soywiz/korge/KorgeHeadless.kt # korgw/src/commonMain/kotlin/com/soywiz/korag/AG.kt
…ext3D # Conflicts: # korge/src/commonMain/kotlin/com/soywiz/korge/Korge.kt # korge/src/commonMain/kotlin/com/soywiz/korge/KorgeHeadless.kt # korgw/src/commonMain/kotlin/com/soywiz/korag/AG.kt
soywiz
reviewed
Sep 28, 2020
Comment on lines
+20
to
+27
class TweenComponent( | ||
override val view: View3D, | ||
private val vs: List<V2<*>>, | ||
val time: HRTimeSpan = HRTimeSpan.NIL, | ||
val easing: Easing = DEFAULT_EASING, | ||
val callback: (Double) -> Unit, | ||
val c: CancellableContinuation<Unit> | ||
) : UpdateComponentV2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole file is duplicated. I think we should try to figure out a way to deduplicate it. Maybe we can create something like BaseView interface that is implemented by View and View3D? Or extract the functionality in a place that could be called in both cases
soywiz
approved these changes
Sep 28, 2020
Thanks @dhakehurst ! A really nice contribution. |
Yes I started copying the tween stuff to 3d. But then stopped as i couldn’t
see how it was supposed to be working. And i also though it was silly to
have a duplicate. Perhaps a generic arg could help?
Am unsure if we can make it common. 3d of course needs an additional
dimension!
…On Mon, 28 Sep 2020 at 14:31, Carlos Ballesteros Velasco < ***@***.***> wrote:
Thanks @dhakehurst <https://github.com/dhakehurst> ! A really nice
contribution.
I will try to generalize some duplicated code so we can deduplicate it, I
will try to do that in a PR so you can review it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABK3WZKHHGODTQVEPC6VTBLSIB6YVANCNFSM4R4IHMZQ>
.
|
In the end I have deduplicated it like this (created BaseView): cf4baf3 |
looks like it could work...would probably have to try it out to be sure.
good start.
…On Mon, 28 Sep 2020 at 18:07, Carlos Ballesteros Velasco < ***@***.***> wrote:
In the end I have deduplicated it like this (created BaseView): cf4baf3
<cf4baf3>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABK3WZPRTY74NLRC7K26V5LSICYDJANCNFSM4R4IHMZQ>
.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.