Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon – advanced searching #28

Open
lennerd opened this issue Sep 28, 2015 · 8 comments

Comments

@lennerd
Copy link
Member

commented Sep 28, 2015

Regarding #18:

Implementing better search feature

Our current search feature is based on Nominatim, which makes it very basic and sometimes unstable.

screenshot 2015-09-28 09 07 15

Wouldn't it be great to use a service, like Photon?

This would give us:

  • enhanced, faster and more stable search functionalities
  • search-as-you-type feature on the map itself

Todos

  • Implement Photon API
  • Implement search-as-you-type feature for the map search field (needs to be discussed and designed)
@voltagex

This comment has been minimized.

Copy link

commented Oct 21, 2015

I can't promise a lot of time on this, but I'd like to take a look.

@holgerd

This comment has been minimized.

Copy link
Member

commented Oct 28, 2015

fyi: Maybe a Photon alternative?
https://mapzen.com/projects/search

@lennerd

This comment has been minimized.

Copy link
Member Author

commented Oct 28, 2015

@voltagex That would be great!

@holgerd Thanks for sharing. The advantage of Photon is that we already implemted this library for the Embed Widget.

@voltagex

This comment has been minimized.

Copy link

commented Oct 30, 2015

I'm trying to avoid this falling off my list of things to do. I have some time this weekend and next (GMT+11, so it's Friday night as I write this). I can code, but I haven't written Ruby before.

Can someone point me in the right direction to get started on this?

@voltagex

This comment has been minimized.

Copy link

commented Oct 30, 2015

I'm assuming this also means hitting photon.komoot.de with all the searches from wheelmap - do we want to check if that's OK? Otherwise is it possible to host our own on wheelmap infrastructure?

@christoph-buente

This comment has been minimized.

Copy link
Member

commented Oct 30, 2015

I checked back with Christoph from Komoot once, and he confirmed there is no problem using http://photon.komoot.de if we keep below 7 requests/second. If we hit more, there is something we can work out with them i guess.

@lennerd

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2015

@voltagex You can find the corresponding part of the app in the search controller: https://github.com/sozialhelden/wheelmap/blob/master/app/controllers/search_controller.rb

Here you will find the current implementation of the Nominatim API. To change this implementation to use Photon should be quite trivial. The maybe a bit more difficult part is to handle the Photon response as Nominatim has an own format and Photon uses GeoJSON.

You find more informations in the corresponding documentations:
Nominatim: http://wiki.openstreetmap.org/wiki/Nominatim
Photon: https://photon.komoot.de/#api

If you have any more questions, don't hesitate to ask.

@voltagex

This comment has been minimized.

Copy link

commented Dec 11, 2015

Time constraints mean I can't take this one on at the moment - I hope I haven't scared anyone else off from having a go at this.

@holgerd holgerd modified the milestones: 3-D Man, A'lars Jan 15, 2016

@holgerd holgerd modified the milestone: A'lars Jan 22, 2016

@holgerd holgerd added the next label May 3, 2016

@lennerd lennerd assigned lennerd and unassigned skade May 3, 2016

@lennerd lennerd added in progress and removed mentored next labels May 3, 2016

@lennerd lennerd removed the next label Jun 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.