Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] Comment field shown on POI detail page even though it's empty #643

Open
1000miles opened this issue Aug 4, 2017 · 0 comments
Open

Comments

@1000miles
Copy link
Collaborator

This is a follow-up ticket of #606 (comment).

Steps to reproduce:

  • I am on https://wheelmap.org/en/nodes/-452678133
  • I click on edit button
  • I sign into osm and I am redirected to the wheelmap POI
  • I can see there is no comment yet for the wheelmap:description tag
  • I click on save button without adding/changing anything in the comment field

=> actual behavior: empty comment field is visible
=> expected behavior: if comment field is empty do not show on wheelmap POI

00000387

Needs clarification:

  • If a wheelmap POI has a previous comment and I remove that comment (by emptying the comment field), should my edit be considered as a total removal of the whole comment or as an update and therefore being saved/synced to osm and back?

Possible solution:

  • Consider all changes as updates and save them in the backend but do not show the comment field in the front-end if it is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant