New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client crash - NPE - Tesselating block model - Preconditions.checkNotNull #1290

Closed
ProsperCraft opened this Issue Mar 14, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ProsperCraft

ProsperCraft commented Mar 14, 2018

https://gist.github.com/owen-pi/ed0ba82491d8d52e64b5122a03dd4051

When looking at an Immersive Engineering waterwheel.

This crash is repeatable and does not happen without Optifine.

@sp614x

This comment has been minimized.

Show comment
Hide comment
@sp614x

sp614x Mar 15, 2018

Owner

The crash is inside Immersive Engineering, the IESmartObjModel tries to create a list with NULL contents.
It should be fixed to check for NULL and use an empty list instead.

https://github.com/BluSunrize/ImmersiveEngineering/blob/master/src/main/java/blusunrize/immersiveengineering/client/models/IESmartObjModel.java#L241

java.lang.NullPointerException: Tesselating block model
	at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:770)
	at com.google.common.collect.Lists.newArrayList(Lists.java:146)
	at blusunrize.immersiveengineering.client.models.IESmartObjModel.getQuads(IESmartObjModel.java:241)
	at blusunrize.immersiveengineering.client.models.IESmartObjModel.func_188616_a(IESmartObjModel.java:206)
	at net.minecraft.client.renderer.BlockModelRenderer.func_187498_b(BlockModelRenderer.java:106)
	at net.minecraftforge.client.model.pipeline.ForgeBlockModelRenderer.func_187498_b(ForgeBlockModelRenderer.java:89)
	at net.minecraft.client.renderer.BlockModelRenderer.func_187493_a(BlockModelRenderer.java:76)
	at net.minecraft.client.renderer.BlockModelRenderer.func_178267_a(BlockModelRenderer.java:55)
Owner

sp614x commented Mar 15, 2018

The crash is inside Immersive Engineering, the IESmartObjModel tries to create a list with NULL contents.
It should be fixed to check for NULL and use an empty list instead.

https://github.com/BluSunrize/ImmersiveEngineering/blob/master/src/main/java/blusunrize/immersiveengineering/client/models/IESmartObjModel.java#L241

java.lang.NullPointerException: Tesselating block model
	at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:770)
	at com.google.common.collect.Lists.newArrayList(Lists.java:146)
	at blusunrize.immersiveengineering.client.models.IESmartObjModel.getQuads(IESmartObjModel.java:241)
	at blusunrize.immersiveengineering.client.models.IESmartObjModel.func_188616_a(IESmartObjModel.java:206)
	at net.minecraft.client.renderer.BlockModelRenderer.func_187498_b(BlockModelRenderer.java:106)
	at net.minecraftforge.client.model.pipeline.ForgeBlockModelRenderer.func_187498_b(ForgeBlockModelRenderer.java:89)
	at net.minecraft.client.renderer.BlockModelRenderer.func_187493_a(BlockModelRenderer.java:76)
	at net.minecraft.client.renderer.BlockModelRenderer.func_178267_a(BlockModelRenderer.java:55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment