Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge 1.13 is not detecting OptiFine #2148

Open
GGWarriorWP opened this issue Jan 4, 2019 · 39 comments

Comments

Projects
None yet
@GGWarriorWP
Copy link

commented Jan 4, 2019

I know forge is still in early dev and not viable for playing or even playtesting, but it seems forge does not detect optifine at all when put in the mods folder.

@realjackasterisk

This comment has been minimized.

Copy link

commented Jan 4, 2019

OptiFine 1.13 was developed before any version of Forge 1.13 was even available, so this is not really surprising.

@sp614x

This comment has been minimized.

Copy link
Owner

commented Jan 10, 2019

Looking at the new Forge patching system and trying to find a way that OptiFine can use.
https://github.com/cpw/modlauncher

@JacobTDC

This comment has been minimized.

Copy link

commented Feb 21, 2019

Could this potentially be done by merging the forge and OptiFine [version].json files?

@realjackasterisk

This comment has been minimized.

Copy link

commented Feb 21, 2019

pretty sure that's not how it works

@JacobTDC

This comment has been minimized.

Copy link

commented Feb 21, 2019

I don't know... I've found that pretty useful for merging other things before. Although, I can't figure out how to get it to work for Forge + OptiFine... It may well be impossible, so that's why I asked.
I'll merge the data and delete the [version].jar, and Forge loads fine, but no sign of OptiFine...

@sp614x

This comment has been minimized.

Copy link
Owner

commented Apr 6, 2019

OptiFine is mostly updated to be compatible with Forge 1.13.2.
One standing problem is that Forge can't load the OptiFine class transformer from the mods folder.
It only works when OptiFine is installed as a library in the classpath.
@cpw knows what is missing and has plans how it can be fixed.

@LafinJack

This comment has been minimized.

Copy link

commented Apr 8, 2019

"It only works when OptiFine is installed as a library in the classpath."

Thank you! So we just drop it in there?

@Tokenyet

This comment has been minimized.

Copy link

commented Apr 14, 2019

Glad to hear that Forge 1.13.2 is working on! I suggested that you could make the issued pinned on the issue page. This could reduce a bit the same duplicated question :P

@NachoMans

This comment has been minimized.

Copy link

commented Apr 14, 2019

How do I install it as a library in the classpath

@Quavelen

This comment has been minimized.

Copy link

commented Apr 14, 2019

How do I install it as a library in the classpath

I would be very interested in an explanation for this as well lol.

@Cadiboo

This comment has been minimized.

Copy link

commented Apr 14, 2019

You would need the developer version of OptiFine (which only sp614x has) loaded into a 1.13.2 Forge mod development workspace. This would put OptiFine on the classpath before Forge loads.
You could also probably do it by making a separate program to launch minecraft that would load OptiFine’s classes before launching Forge. However this defeats the entire “plug and play” aim of Forge and isn’t very friendly for end-users.
The Forge devs are currently away/tied up with their real jobs/working on more important stuff/maintaining 1.12.2/updating their mods to 1.13.2 right now, but they’re going to work on this soon™️
All of Forge is open source so you could also submit a PR to fix/add this here

@Quavelen

This comment has been minimized.

Copy link

commented Apr 15, 2019

Well, thank you for that explanation @Cadiboo. Since I certainly don't have access to sp614x's dev version, and I don't have the knowledge/knowhow to make a program to do that, it's out of my reach.

I'm aware the Forge devs are busy, and working hard. If I was remotely intelligent enough to offer help, I would. Pretty sure I'm below average though, and my lack of any basic understanding of any code, also puts a wrench in that.

Think of my above interest in the library classpath thing, as a "wait, we can use it before it's released?" moment of thought. Your explanation confirms that, but also tells me it's impossible for me lol. So thank you again.

@Cadiboo

This comment has been minimized.

Copy link

commented Apr 15, 2019

The actual issue is that Forge only loads OptiFine’s patch application code when OptiFine is on the classpath (i.e. in a development environment or pre-loaded by something else), Forge doesn’t load OptiFine’s classes from the mods folder (yet). 99% of the work to get Forge and OptiFine to be compatible has been done and as soon as Forge changes this OptiFine will be able to be loaded as a mod by Forge (except for the fact that OptiFine doesn’t contain a mods.toml file (yet?) to identity it as a mod)

@xfl03

This comment has been minimized.

Copy link

commented Apr 15, 2019

@Cadiboo
Not only the problem of mods.toml .
1.13.2 FML uses a new transformation system named CoreMods. It only allows mod to transform class using JavaScript, OptiFine did not make it yet, which causes FML does not recognize and load it.
In FML before 1.13.2, FML can load LaunchWrapper Tweaker, but now it is replaced with ModLauncher, it is the reason why OptiFine cannot be loaded now.

@Barteks2x

This comment has been minimized.

Copy link

commented Apr 15, 2019

You are right that it's not really about mods.toml. But the issue isn't that the new transformation system is different, but that it actually has features that aren't fully implemented yet. OptiFine won't use the javascript coremod system. If I understand it right, OptiFine will use the system that that is used by the CoreMods system. It works fine for CoreMods, because it's on the classpath. And FML can't load something like this from mods folder yet. When option to load it is implemented, then optifine will work with forge.

@Cadiboo

This comment has been minimized.

Copy link

commented Apr 15, 2019

The mods.toml issue thing is an issue with OptiFine, without it everything should still work (ServicePlugins are completely separate from mods AFAIK), but users won’t be able to see OptiFine as an installed mod and it won’t show up anywhere without it. It’s a small issue that is easily fixable if sp614x wants users to be able to see OptiFine in the mods list.

OptiFine does not use the new CoreMods system at all, it uses a ServicePlugin from ModLauncher (I think, I haven’t been able to find anything in the OptiFine HD_U_E8-pre mod jar).

@sp614x

This comment has been minimized.

Copy link
Owner

commented Apr 15, 2019

The public preview can't be loaded as a library yet. It would need to be packed differently with SRG classes and the forge class transformer configuration added.

@NachoMans

This comment has been minimized.

Copy link

commented Apr 24, 2019

1.14 is out and 1.13 optifine isn't even ready for forge lol.

@realjackasterisk

This comment has been minimized.

Copy link

commented Apr 24, 2019

because forge isn't ready for optifine

@LafinJack

This comment has been minimized.

Copy link

commented Apr 24, 2019

Because Mojang keeps changing everything in the underlying structure of the game and Forge and Optifine are being written for free by volunteers.

@mrcoffee1026

This comment has been minimized.

Copy link

commented Apr 27, 2019

really just read a changelog or two... less speculation == a lot less confusion about this:
OptiFine 1.13.2_HD_U_E8_pre1

  • fixed shader programs above composite9 and deferred9 (#2251)
  • fixed translucent block ordering with shadowmap (#2287)
  • fixed shaders normal/specular textures (#2286)
  • fixed structure void rendering (#847)
  • internally compatible with Forge 25.0.90 (can't be installed yet)
    (05.04.2019)
@Cadiboo

This comment has been minimized.

Copy link

commented Apr 27, 2019

internally compatible with Forge 25.0.90 (can't be installed yet)
(05.04.2019)

Means that OptiFine’s patches are compatible with Forges patches. It doesn’t mean that it’s ready to be loaded by Forge.

@mrcoffee1026

This comment has been minimized.

Copy link

commented Apr 28, 2019

Yes, I think that's why they said "can't be installed yet"

@sp614x sp614x changed the title Forge 1.13 pre-alpha not is not detecting optifine Forge 1.13 not is not detecting OptiFine May 3, 2019

@sp614x sp614x changed the title Forge 1.13 not is not detecting OptiFine Forge 1.13 is not detecting OptiFine May 3, 2019

@GGWarriorWP

This comment has been minimized.

Copy link
Author

commented May 28, 2019

I have been told that forge is now able to load optifine from the mods folder, but it still doesn't work for me using optifine E7

@Cadiboo

This comment has been minimized.

Copy link

commented May 28, 2019

This appears to be right, Forge should now be able to load OptiFine. It won’t load existing jars though, because

The public preview can't be loaded as a library yet. It would need to be packed differently with SRG classes and the forge class transformer configuration added.

@NKSHV

This comment has been minimized.

Copy link

commented Jul 4, 2019

It still does not work

@Vexima

This comment has been minimized.

Copy link

commented Jul 4, 2019

You need to wait. Forge compatibility is coming soon - Forge has the necessary stuff to make OptiFine work - we just need to be patient. Coding isn't done instantly, but it's now possible to expect compatibility soon!

@mrcoffee1026

This comment has been minimized.

Copy link

commented Jul 4, 2019

Actually, given the quantity of releases of optifine without forge support - and only for 1.14+ - I doubt they will be further implementing compatibility for 1.13. As many plugin developers have taken this approach as well: abandoning 1.13 as unfixable, and moving on to 1.14 instead. What I would hope for ijn the future is any indication that they intend to make 1.14 compatible with forge again, ever... as the increasing number of releases and pre-releases without suggest otherwise.

@Vexima

This comment has been minimized.

Copy link

commented Jul 4, 2019

Good point - I'm usually talking about 1.14. Yes, I don't think it will come for 1.13 - only 1.14.3/.4

@Mohamedking898

This comment has been minimized.

Copy link

commented Jul 7, 2019

Progresses?

@SupinePandora43

This comment has been minimized.

Copy link

commented Jul 7, 2019

@Mohamedking898 nothing...

@Vexima

This comment has been minimized.

Copy link

commented Jul 7, 2019

I still think that 1.13 to 1.14.2 (possibly 1.14.3) will never have Forge support, unless a mod comes along that allows Forge and OptiFine to work (ie OptiFabric for Forge).

@Studio528-real

This comment has been minimized.

Copy link

commented Jul 7, 2019

I agree with vexima for the most part, its likely that forge support will come for 1.14.3 if 1.14.4 doesn't come out first, forge has added what was needed for optifine so now its just a waiting game for sp614x to update optifine, but its most likely that 1.13-1.14.2 will not get forge, mainly bc forge doesn't have what's needed for optifine to be compatible in those versions and probably won't be updated to have them.

@sp614x

This comment has been minimized.

Copy link
Owner

commented Jul 7, 2019

Added all Forge 1.14.3 patches to OF. Now Forge crashes in a very strange way.

@epicmarkvan

This comment has been minimized.

Copy link

commented Jul 8, 2019

Added all Forge 1.14.3 patches to OF. Now Forge crashes in a very strange way.

Strrange as in "Optifine still won't be compatible for a bit" or "Funny but an easy fix"?

@sp614x

This comment has been minimized.

Copy link
Owner

commented Jul 9, 2019

Crash fixed, now OF can run with Forge when installed as a library.
Next step is to make it load from the "mods" folder.

@epicmarkvan

This comment has been minimized.

Copy link

commented Jul 11, 2019

Crash fixed, now OF can run with Forge when installed as a library.
Next step is to make it load from the "mods" folder.

How do I install OF as a library? Really want to use them together.

@Quavelen

This comment has been minimized.

Copy link

commented Jul 11, 2019

Crash fixed, now OF can run with Forge when installed as a library.
Next step is to make it load from the "mods" folder.

How do I install OF as a library? Really want to use them together.

Please see the replies after my comment here: #2148 (comment)

In a nutshell though - you can't. We, I guess. Only sp614x can, as he has the required files and whatever to do it.

@sp614x

This comment has been minimized.

Copy link
Owner

commented Jul 13, 2019

Loading from mods folder is generally working, but crashes with some classes.
ModLauncher needs a bugfix:
cpw/modlauncher#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.