New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in cape downloader #526

Closed
prplz opened this Issue Mar 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@prplz

prplz commented Mar 14, 2017

The IImageBuffer CapeUtils$1 keeps hold of player objects after it is done with them. This causes every player you have seen who has an optifine cape to be kept in memory forever.

When playing on minigames servers with constant world changes this also causes many worlds to be kept in memory.

As an example, after playing hypixel for about two hours my game was at 90% memory usage, causing unplayable gc spikes.

Suggested fix: instead of using a final player in the anonymous class, use the player's name to find the relevant player in the world's player list.

@sp614x sp614x added the bug label Mar 16, 2017

@sp614x sp614x added the todo label May 30, 2017

@sp614x

This comment has been minimized.

Owner

sp614x commented Jul 23, 2017

Updated preview C5 for 1.12

  • fixed memory leak in cape download

@sp614x sp614x closed this Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment