Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mkPackage from template #320

Closed
justinwoo opened this issue Jul 14, 2019 · 1 comment

Comments

@justinwoo
Copy link
Collaborator

commented Jul 14, 2019

mkPackage, the little function that never quite was 馃槩 馃幒 (<-- this plays Taps, or auld lang syne, depending on your religion)

purescript/package-sets#399

@f-f

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

While I have no solution for the emoji rebus, I think we should also output a warning for folks that still have it in their packages.dhall (i.e. either traverse the AST or just grep searching for "mkPackage"), so that they can migrate and we can remove it from package-sets when releasing 1.0

@f-f f-f closed this in #322 Jul 19, 2019

f-f added a commit that referenced this issue Jul 19, 2019

Remove mkPackage Dhall function and switch to package-sets releases (#鈥
鈥322)

Upgrade to purescript/package-sets#399

Changes:
- Remove `mkPackage` from template (fix #320)
- Switch to `packages.dhall` from releases (fix #319)
- Replace call to the GitHub API with just looking for a redirect when looking 
  for the latest package set. This is to prevent API ratelimiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.