Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --purs-command flag to customize calls to the compiler #283

Closed
wants to merge 2 commits into from

Conversation

@f-f
Copy link
Member

commented Jun 18, 2019

This allows to customize the command used by Spago to call the compiler (defaults to purs), and so it should fix #252 assuming that the command specified is CLI-compatible with purs

However, it looks like psa is not CLI-compatible, so I'm slightly dubious on the usefulness of this. E.g. this is what happens if I run some command using psa as command:

$ spago -v -p psa install
Running `spago install`
Ensuring that the package set is frozen
Getting transitive deps
Running `fetchPackages`
Checking if `purs` is up to date
Running command: `psa --version`
spago: Oh noes! It looks like the PureScript version installed on your system is not compatible with the package-set you're using.

installed `purs` version:    0.7.3
minimum package-set version: 0.13.0

...

That is, psa --version behaves differently from purs --version, and this confuses spago (that is expecting 0.13.0 instead of 0.7.3 there)

cc @joneshf

f-f added some commits Jun 17, 2019

@joneshf

This comment has been minimized.

Copy link

commented Jun 19, 2019

Hmm. That's a shame. I guess what I ultimately want is for purs to output errors. It's quite the pain that it chooses not to do that and instead of forces that downstream to tools like psa and causes all of this complexity. None of this is really something you need to solve here.

If it can't happen, it can't happen. Thanks for trying, though!

@f-f

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

@joneshf makes sense! You're welcome 🙂

I'll close this and #252 then

@f-f f-f closed this Jun 19, 2019

@f-f

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Reopening as requested on Slack

@f-f f-f reopened this Jul 3, 2019

@f-f f-f referenced this pull request Jul 9, 2019

Merged

Use `psa` for compiling if installed #305

1 of 3 tasks complete

@f-f f-f closed this in #305 Jul 9, 2019

@f-f f-f deleted the custom-purs-command branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.