Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-config-format flag. Fixes #300. #302

Merged
merged 3 commits into from Jul 7, 2019
Merged

Add --no-config-format flag. Fixes #300. #302

merged 3 commits into from Jul 7, 2019

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jul 5, 2019 •
edited

Description of the change

  • Add dontFormatConfig to GlobalOptions
  • Add condition to Spago.Dhall.writeRawExpr with Bool parameter

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

Add --no-config-format global flag. Fixes purescript#300.
be3041e 
- Add `dontFormatConfig` to `GlobalOptions`
- Add condition to `Spago.Dhall.writeRawExpr` with `Bool` parameter
@aniketd aniketd force-pushed the 300-add-no-config-format-global-option branch from 2e818d2 to be3041e Compare July 5, 2019 19:03
@aniketd aniketd mentioned this pull request Jul 5, 2019
Closed
f-f
f-f reviewed Jul 6, 2019
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor suggestions 🙂

src/Spago/Dhall.hs Outdated Show resolved Hide resolved
src/Spago/Dhall.hs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Address review comments.
3b410fc 
- Write the file unconditionally in `writeRawExpr`
- Change wording in `CHANGELOG.md`
- Change `Bool` to `data DoFormat = DoFormat | NoFormat deriving (Eq)`
- Move conditional formatting check inside `Spago.Dhall.format`
@aniketd
Copy link
Contributor Author

aniketd commented Jul 7, 2019 •
edited

Thanks for the insightful review. 😄 I have made another commit that addresses all the changes requested 👍

f-f
f-f approved these changes Jul 7, 2019
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aniketd looks good, thanks! 🙌

@f-f f-f merged commit 3be573a into purescript:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-f f-f f-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aniketd @f-f