Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--no-config-format` flag. Fixes #300. #302

Merged

Conversation

@aniketd
Copy link
Contributor

commented Jul 5, 2019

Description of the change

  • Add dontFormatConfig to GlobalOptions
  • Add condition to Spago.Dhall.writeRawExpr with Bool parameter

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)
Add `--no-config-format` global flag. Fixes #300.
- Add `dontFormatConfig` to `GlobalOptions`
- Add condition to `Spago.Dhall.writeRawExpr` with `Bool` parameter

@aniketd aniketd force-pushed the aniketd:300-add-no-config-format-global-option branch from 2e818d2 to be3041e Jul 5, 2019

@f-f
Copy link
Member

left a comment

Looks good! Just some minor suggestions 🙂

Show resolved Hide resolved src/Spago/Dhall.hs Outdated
Show resolved Hide resolved src/Spago/Dhall.hs Outdated
Show resolved Hide resolved CHANGELOG.md Outdated
Show resolved Hide resolved CHANGELOG.md Outdated
Address review comments.
- Write the file unconditionally in `writeRawExpr`
- Change wording in `CHANGELOG.md`
- Change `Bool` to `data DoFormat = DoFormat | NoFormat deriving (Eq)`
- Move conditional formatting check inside `Spago.Dhall.format`
@aniketd

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

Thanks for the insightful review. 😄 I have made another commit that addresses all the changes requested 👍

@f-f

f-f approved these changes Jul 7, 2019

Copy link
Member

left a comment

@aniketd looks good, thanks! 🙌

@f-f f-f merged commit 3be573a into spacchetti:master Jul 7, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.