Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the list-packages command #304

Merged
merged 2 commits into from Jul 9, 2019

Conversation

@f-f
Copy link
Member

commented Jul 8, 2019

To avoid regressions as I risked in #301 (see #301 (comment) for more context)

@f-f f-f referenced this pull request Jul 8, 2019
10 of 10 tasks complete
test/SpagoSpec.hs Show resolved Hide resolved
@f-f

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

Interesting, the spago list-packages command seems to hang when run inside the tests on both macOS and Windows (I can reproduce on my mac) 🤔

EDIT: see here:

Question: My program hangs when I run a subprocess that reads from standard input. What do I do?

Answer: Make sure you compile your program with the -threaded flag

@f-f f-f merged commit 08b09c4 into master Jul 9, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@f-f f-f deleted the add-list-packages-tests branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.