Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch all sources, including dependencies, when building #309

Merged
merged 5 commits into from Jul 17, 2019

Conversation

@f-f
Copy link
Member

commented Jul 10, 2019

Fix #172

@f-f f-f referenced this pull request Jul 10, 2019

f-f added some commits Jul 10, 2019

@f-f

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2019

While debugging this with @jmackie we figured that it works for most paths, except for the ones that have this shape:

"/some/folder/../lib/purescript-stuff/src/**/*.purs"

And I suspect the Glob library does not properly match files in this case, so we should canonicalize the path. So let's hold this until #301 goes in, and then see if this gets fixed (because Dhall already canonicalizes), otherwise we'll have to canonicalizePath when calling getGlobs

@f-f f-f added the blocked label Jul 16, 2019

@f-f f-f referenced this pull request Jul 17, 2019
10 of 10 tasks complete

@f-f f-f removed the blocked label Jul 17, 2019

@f-f

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

I'll merge this now since we need to get this in anyways, and I added a checkbox in #301

@f-f f-f merged commit 3eaba10 into master Jul 17, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@f-f f-f deleted the watch-all-globs branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.