Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for local dependencies #310

Merged
merged 2 commits into from Jul 10, 2019

Conversation

@elliotdavies
Copy link
Contributor

commented Jul 10, 2019

Adds a test for this monorepo-style scenario where all packages share a single packages.dhall and dependencies must be listed in spago-deps.dhall files to avoid circular dependencies:

  • app
    • spago.dhall
    • packages.dhall
    • lib-a
      • spago.dhall
      • spago-deps.dhall
    • lib-b
      • spago.dhall
      • spago-deps.dhall

Once this goes into master I can put in another PR against #301 to update it.

elliotdavies added some commits Jul 10, 2019

@f-f

f-f approved these changes Jul 10, 2019

Copy link
Member

left a comment

Looks great, thank you! 👏🎉

@f-f f-f merged commit 0ae9dea into spacchetti:master Jul 10, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@elliotdavies elliotdavies deleted the elliotdavies:feature/spago-build-tests branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.