Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mkPackage Dhall function and switch to package-sets releases #322

Merged
merged 10 commits into from Jul 19, 2019

Conversation

@f-f
Copy link
Member

commented Jul 15, 2019

Upgrade to purescript/package-sets#399

Changes:

  • remove mkPackage from template (fix #320)
  • switch to packages.dhall from releases (fix #319)

TODO:

  • Remove remaining references of mkPackage from README and tests
  • Wait for #301 to be merged update: we don't need to wait, but we'll need to be careful in there so that we don't miss references to mkPackage
  • Port Curator to the new format of package-sets
  • Add test for the migration
  • Add dhall lint invocation to remove unused bindings in packages.dhall EDIT: skipping this, so many corner cases
  • Add warning to remove mkPackage if we detect it somewhere EDIT: crawling the AST is lots of work, and just grepping has false positives. Giving up is fine, because the schema is backwards compatible.

@f-f f-f referenced this pull request Jul 15, 2019

Open

Deprecations for `1.0` #291

0 of 5 tasks complete

f-f added some commits Jul 15, 2019

f-f added some commits Jul 15, 2019

@f-f f-f referenced this pull request Jul 18, 2019

Merged

Import local packages `as Location` #301

10 of 10 tasks complete

@f-f f-f merged commit 3f5aa37 into master Jul 19, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@f-f f-f deleted the remove-mkPackage branch Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.