Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GIT-REPO#version versions in bower.json for packages that are not found in Bower. #324

Merged
merged 19 commits into from Jul 19, 2019

Conversation

@Dretch
Copy link
Collaborator

commented Jul 15, 2019

This is a follow-on from #303.

Checklist:

  • Added a test for the contribution (if applicable)

f-f and others added some commits Jul 8, 2019

src/Spago/Bower.hs Outdated Show resolved Hide resolved

Dretch added some commits Jul 15, 2019

src/Spago/Bower.hs Outdated Show resolved Hide resolved

Dretch added some commits Jul 16, 2019

@Dretch Dretch marked this pull request as ready for review Jul 17, 2019

deps <- Packages.getDirectDeps config

for deps $ \(PackageName{..}, Package{..}) -> do

This comment has been minimized.

Copy link
@f-f

f-f Jul 18, 2019

Member

I was wondering if we should do this in parallel, as from what I've seen bower info can be quite slow. We could use an async pool like we do here, or just mapTasks as we don't need the fancy error handling

This comment has been minimized.

Copy link
@f-f

f-f Jul 19, 2019

Member

(this is not a requirement for merging, just noting that it might a bottleneck on larger packages)

This comment has been minimized.

Copy link
@Dretch

Dretch Jul 19, 2019

Author Collaborator

Yeah - done. Bower info is pretty slow (it takes a couple of seconds per call here, but I do have very high latency internet).

@f-f

f-f approved these changes Jul 19, 2019

Copy link
Member

left a comment

Thanks @Dretch, good work! (especially with the Windows stuff 😄)

f-f and others added some commits Jul 19, 2019

@f-f f-f referenced this pull request Jul 19, 2019
0 of 3 tasks complete

Dretch and others added some commits Jul 19, 2019

Run multiple calls `bower info ...` in parallel instead of serially, …
…because it is slow (~2s per call on my machine)

@Dretch Dretch merged commit aa1a327 into master Jul 19, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Dretch Dretch deleted the remove-metadata-check-in-version branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.