Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs search #333

Merged
merged 9 commits into from Jul 29, 2019

Conversation

@klntsky
Copy link
Collaborator

commented Jul 24, 2019

The binary size is now 48MB.

Some more features to consider:

  • Add a CLI flag that disables docs patching when running spago docs.
  • Add ability to skip compilation when running spago search.
  • Pin JS files by hash

Fix #89

klntsky added some commits Jul 23, 2019

@f-f

f-f approved these changes Jul 25, 2019

Copy link
Member

left a comment

@klntsky I left some minor comments but otherwise looks great! 👏

src/Spago/Build.hs Show resolved Hide resolved
app/Spago.hs Show resolved Hide resolved
src/Spago/Templates.hs Show resolved Hide resolved

f-f added some commits Jul 26, 2019

@f-f

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

@klntsky I'll merge now so we can include this in today's release. Thank you for doing this! 🙂

@f-f f-f merged commit d8cd326 into spacchetti:master Jul 29, 2019

3 checks passed

Summary 2 potential rules
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

klntsky added a commit to klntsky/spago that referenced this pull request Jul 29, 2019

f-f added a commit that referenced this pull request Jul 29, 2019

@googleson78

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

This is awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.