Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dry-run machinery so we print a clear list of dry actions #338

Merged
merged 11 commits into from Jul 28, 2019

Conversation

@f-f
Copy link
Member

commented Jul 26, 2019

Also make the --jobs flag global instead of passing it around everywhere

New output:

$ spago bump-version minor
Generating bower.json using the package set versions..
Generated bower.json using the package set
No git version tags found, so assuming current version is v0.0.0
Running `bower install` so `pulp publish` can read resolved versions from it

WARNING: this is a dry run, so these side effects were not performed:
- create new git tag "v0.1.0"

Use the `--no-dry-run` flag to run them
Refactor dry-run machinery so we print a clear list of dry actions
Also make the --jobs flag global instead of passing it around

@f-f f-f requested a review from Dretch Jul 26, 2019

f-f added some commits Jul 26, 2019

@Dretch
Copy link
Collaborator

left a comment

Makes sense and mostly looks good to me (I just left some comments).

Show resolved Hide resolved src/Spago/Bower.hs Outdated
Show resolved Hide resolved src/Spago/Version.hs Outdated

f-f added some commits Jul 27, 2019

@Dretch

Dretch approved these changes Jul 27, 2019

@Dretch

This comment has been minimized.

Copy link
Collaborator

commented on src/Spago/Version.hs in 998cfbf Jul 27, 2019

I suppose that that generation of the bower.json content (which might fail - e.g. because of local dependencies) could be always done -- with only the actual writing of the file in the DryAction?

This comment has been minimized.

Copy link
Member Author

replied Jul 27, 2019

Right, I wanted to split that but I forgot. I'll change it 👍

@f-f f-f merged commit 03c4a12 into master Jul 28, 2019

3 checks passed

Summary 1 rule matches and 1 potential rule
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@f-f f-f deleted the refactor-dry-run branch Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.