Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reformatting the config file at every run #339

Merged
merged 3 commits into from Jul 29, 2019

Conversation

@f-f
Copy link
Member

commented Jul 29, 2019

Fix #300

This implements the fix described in #300 (comment): we remove the --no-config-format flag and Spago will not reformat the config file unless it's needed, removing the need for the flag

cc @joneshf @LiamGoodacre @aniketd: since there is some noise in the PR, the actual fix for this is basically these lines

@LiamGoodacre
Copy link

left a comment

Looks great

f-f added some commits Jul 29, 2019

@f-f f-f merged commit 826faef into master Jul 29, 2019

3 checks passed

Summary 1 rule matches and 1 potential rule
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@f-f f-f deleted the fix-reformatting-at-every-run branch Jul 29, 2019

@joneshf

This comment has been minimized.

Copy link

commented Jul 29, 2019

Thanks for keeping me in the loop!

@f-f

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

You're welcome 🙂

@aniketd

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

Thanks @f-f 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.