Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have PhysicsManager use DynamicTree #955

Merged

Conversation

@Tyler-IN
Copy link
Contributor

Tyler-IN commented Feb 6, 2020

IBroadPhase and BroadPhaseNaive are unused now, though.

Rushed.

@Tyler-IN Tyler-IN requested review from Acruid, PJB3005 and Silvertorch5 as code owners Feb 6, 2020
@PJB3005

This comment has been minimized.

Copy link
Member

PJB3005 commented Feb 6, 2020

I think it'd probably be better if this was properly integrated with IBroadPhase, but I'll let @Acruid be the final judge on that.

@Tyler-IN

This comment has been minimized.

Copy link
Contributor Author

Tyler-IN commented Feb 6, 2020

IBroadPhase would have to change drastically, I think it is a bit overcomplicated, maybe based on other physics abstraction approaches.

PhysicsManager is technically doing the broad phase collision operation, the DynamicTree is just a data structure.

add BroadPhase wrapping DynamicTree

replace IBroadPhase with regards to DynamicTree
@Tyler-IN

This comment has been minimized.

Copy link
Contributor Author

Tyler-IN commented Feb 6, 2020

I went the more evil route and replaced IBroadPhase in order to separate out BroadPhase from DynamicTree from PhysicsManager.

Tyler-IN added 2 commits Feb 7, 2020
… shutdown

reduce code footprint of alternate query in AnyEntitiesIntersecting by using existing query (only used rarely)
@Acruid Acruid merged commit 5d37780 into space-wizards:master Feb 7, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.