New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction Entity System #26

Merged
merged 7 commits into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@clusterfack
Member

clusterfack commented Feb 2, 2018

Fixes #20

Interaction system parses click on clickablecomponents within range of the attacker into attackhand, attackby, and useentity. It makes it so if you want something to have attackhand, attackby, or item use functionality you only need to add the interface and define the function.

Replaces the need for interactable component on anything that can be interacted with, and replaces the need to register attackhand, attackby, or item use on the interactable component. This would likely have been an annoyance at least and a point of failure for new coders at worst.

WIP: Primarily just need a way to hook into the clickable component so that it will know to fire the interaction system. I've tacked on some hacky add/remove event onto components that use the interactions but that is obviously far from what I wanted to do.

I also think assigning it to the delegate is somewhat silly and would rather have the interaction system get directly called but since the clickable component is in the engine I can't do that.

Also requires clicktype PR on the engine repo

@clusterfack clusterfack requested review from PJB3005 and Silvertorch5 as code owners Feb 2, 2018

@wafflebot wafflebot bot added the review label Feb 2, 2018

@clusterfack clusterfack force-pushed the clusterfack:interactionsystem branch from 42c1317 to a9c6977 Feb 3, 2018

@clusterfack clusterfack referenced this pull request Feb 3, 2018

Merged

Adds Basic Tools #27

@clusterfack

This comment has been minimized.

Member

clusterfack commented Feb 3, 2018

Help fix shitcode, where should I put a hook into clickable to register it or tell it to use the interaction entity system

@Silvertorch5 Silvertorch5 self-assigned this Feb 3, 2018

@clusterfack clusterfack changed the title from Interaction Entity System (wip) to Interaction Entity System Feb 5, 2018

@clusterfack clusterfack force-pushed the clusterfack:interactionsystem branch from 2d6ccb3 to d84047b Feb 5, 2018

@clusterfack

This comment has been minimized.

Member

clusterfack commented Feb 5, 2018

Updated submodule so this works now

@Silvertorch5 Silvertorch5 merged commit 1452502 into space-wizards:master Feb 5, 2018

@clusterfack clusterfack deleted the clusterfack:interactionsystem branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment