New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting language used for tooling and as hard build dependency. #261

Closed
PJB3005 opened this Issue Jul 6, 2017 · 12 comments

Comments

Projects
None yet
6 participants
@PJB3005
Member

PJB3005 commented Jul 6, 2017

So the problem is that to do things like git hooks, buildResourcePack and other things need to be written in a certain language. Of course, Windows is a pile of crap and can't standardize so we can't just assume everybody has Python or bourne shell installed.

So what do we do?

We can either say "nope, Python is required to build" and just give people a link to the installer for Python 3. But people like @clusterfack disagree with this.

Or we'll have to maintain build scripts, etc... in multiple languages, which is a pain in the butt.

What do we do?

I still advocate going with Python 3 and telling people to get off their butt to install it, it doesn't take that long.

@agrecascino

This comment has been minimized.

agrecascino commented Jul 6, 2017

+1, people who can't install Python probably shouldn't code.

@PJB3005

This comment has been minimized.

Member

PJB3005 commented Jul 6, 2017

Compiling Python scripts like that is just gonna bloat the Git history incredibly quickly, which I'd like to avoid.

@clusterfack

This comment has been minimized.

Member

clusterfack commented Jul 6, 2017

I highly doubt it will make a noticeable difference

@PJB3005

This comment has been minimized.

Member

PJB3005 commented Jul 6, 2017

Run buildResourcePack.py through it and we'll see.

@psykzz

This comment has been minimized.

Contributor

psykzz commented Jul 6, 2017

Why do we even have the buildresource.py?
Can we not just have the zip hosted and downloaded? Ideally automatically from the client (customizable in config).

Why does this even need to be a step in the server repo

@psykzz

This comment has been minimized.

Contributor

psykzz commented Jul 6, 2017

If we have to keep it I'm okay forcing python 3 for our build third party scripts

@PJB3005

This comment has been minimized.

Member

PJB3005 commented Jul 6, 2017

buildResourcePack.py isn't the only thing that'll need it. It's just an example.

@El-Wray

This comment has been minimized.

El-Wray commented Jul 7, 2017

  1. What you think about Bash or Shell? This scripting system built-in Mac and Linux OS. On Windows I use "Git for Windows" and this scripting systems present there too in "...\git for windows\usr\bin" folder.
    I think this is good cross platform solution. But in this case user should add binary folder ("...\git for windows\usr\bin") to system paths. On Windows 10 user can install "Bash on Ubuntu".

  2. Or we can use MSBuild for our purposes. It's cross platform and shipped with .NET Core. (https://github.com/Microsoft/msbuild) And in the future maybe project will be moved on .NET Core. I'm vote for this solution 👍

@PJB3005

This comment has been minimized.

Member

PJB3005 commented Jul 7, 2017

  1. I'm fine with shell but there's a few problems, namely the fact that the default set of UNIX tools included with git is incredibly small, and it doesn't even come with ones like bc. It's possible but not pleasant. Second of all there's the issue that we need to be capable of locating the git installation and Mingw reliably.

  2. I'm not sure msbuild is powerful enough for our purposes, and it isn't exactly a scripting language you'd use for common scripts, especially complicated ones.

@theOperand

This comment has been minimized.

Contributor

theOperand commented Jul 8, 2017

@PJB3005

This comment has been minimized.

Member

PJB3005 commented Jul 10, 2017

Silver decided on Python 🐍.

@PJB3005 PJB3005 closed this Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment