Skip to content

Shut up a child throwing a tantrum#28538

Merged
PJB3005 merged 2 commits intospace-wizards:masterfrom
PJB3005:24-06-03-child
Jun 3, 2024
Merged

Shut up a child throwing a tantrum#28538
PJB3005 merged 2 commits intospace-wizards:masterfrom
PJB3005:24-06-03-child

Conversation

@PJB3005
Copy link
Copy Markdown
Member

@PJB3005 PJB3005 commented Jun 3, 2024

No description provided.

@PJB3005 PJB3005 changed the title 24 06 03 child Shut up a child throwing a tantrum Jun 3, 2024
@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Jun 3, 2024
@PJB3005 PJB3005 merged commit 307a042 into space-wizards:master Jun 3, 2024
@PJB3005 PJB3005 deleted the 24-06-03-child branch June 3, 2024 01:05
@Just-a-Unity-Dev
Copy link
Copy Markdown
Contributor

this looks pretty bad with lack of context

@Kadeo64
Copy link
Copy Markdown
Contributor

Kadeo64 commented Jun 3, 2024

this looks pretty bad with lack of context

it's funny to check is:pr is:merged and see this

@FairlySadPanda
Copy link
Copy Markdown
Contributor

FairlySadPanda commented Jun 4, 2024

Raised the process fault here on voice chat but just to re-iterate:

This will happen whenever an additional person - usually a non-technical contributor, like a spriter or audio technician, gets their work in-game via the help of a friendly contributor.

There should be a new row added to PRs to list contributors who should be added to the credits that are not the person making the PR, and there needs to be a process for adding these people in along with the main contributor.

If you want to be very spicy, crediting properly is an important thing that comes up in games, particularly when the studio has union people inside it. Asking "how do you want to be credited" and then listing the name of the contributor as specified rather than just their Github handle might be wise.

@TsjipTsjip
Copy link
Copy Markdown
Contributor

I should also add that this is presently possible, if the helping contributor knows how, to add a coauthor to a commit. This essentially attributes the "authorship" of a commit to the helping contributor and the artist, and this is respected by the currently in-place system for listing all contributors. This is a built-in feature in Git, which GitHub is compliant with.

This does not fully cover it, as FairlySadPanda has raised above, sometimes artists might want to be credited through more than their GitHub handle, but that in itself would require a whole new system as well.

Co-authors usage To add a co-author to a commit, the commit message must end with a blank line followed by a co-authors line for each co-author of the commit.

Example:

Add functionality to manually add contributors to the contributions list.

Co-authored-by: GITHUB-NAME-OF-AUTHOR <COMMITTER-EMAIL-OF-AUTHOR>

Where you can substitute GITHUB-NAME-OF-AUTHOR and COMMITTER-EMAIL-OF-AUTHOR with the correct values.

@deltanedas
Copy link
Copy Markdown
Contributor

i think a bot like cl would be good

Credits:
- my preferred name
- space jesus

where the default is just your username

@space-wizards space-wizards locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Changes: No C# Changes: Requires no C# knowledge to review or fix this item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants