Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dakka #307

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@metalgearsloth
Copy link
Contributor

commented Aug 18, 2019

So there's a few changes here:

  1. The appearance component won't show the highest state unless the mag is reloaded with ammo left due to the first round being chambered which seemed like a waste of the graphic but this is subjective so I added capacity - 1.

  2. The Content helper for RoundToLevels I changed so something like the AK for example that has 3 sprites: no mag, short mag, and full mag will go:
    Any ammo -> full mag
    No ammo -> short mag
    No mag -> No mag
    Whereas before (combined with the appearance component) the top level state is only used until a round is fired which didn't seem as nice. This is also subjective.

  3. I've left the stuff that needs additional components for another commit (revolvers, shotguns, energy, launchers) because this one's already bigger than it should be.

  4. I added damage to the projectile component just so each bullet type can specify its damage so something like high-velocity rounds can be faciliated. Same deal with velocity.

  5. I changed the magazine stuff to be a list rather than a specific value so stuff like the machinepistols can take both SMG and pistol 9mm ammo but the pistols can't take the smg ammo.

  6. None of the stuff is balanced at the moment (I'd probably drop the smg firerates as a start).

  7. I have 0 idea what the L magazines are supposed to do but I've just left them in as duplicates of the regular magazines.

Add more dakka
Some slight codebase changes to facilitate more robust behaviour.
@PJB3005

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

That's a lot of dakka.

metalgearsloth and others added 2 commits Aug 22, 2019
Update Content.Server/GameObjects/Components/Projectiles/ProjectileCo…
…mponent.cs

Co-Authored-By: Pieter-Jan Briers <pieterjan.briers@gmail.com>
Remix last stereo to mono
hpistol + ltrifle

@PJB3005 PJB3005 merged commit 9431011 into space-wizards:master Aug 22, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.