Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power Redesign (WIP) #715

Closed
wants to merge 11 commits into from
Closed

Power Redesign (WIP) #715

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2020

lost motivation to work on this, very WIP, very much a mess, went through various merges and goofs, help i can't do this

Final product of this should follow PJB's design on the hackmd with substations and whatnot

What's been done:

  • Defined 3 different wire types that only connect to eachother
  • Basic untested framework for LV wire ranged connections (only implemented in PowerNodeComponent because i don't know)
  • Power nodes have a wire type variable now

Issues with what's implemented:

  • MV and LV wires will smooth to each other even though they don't actually connect because they use the same sprite
  • HV wires still power basically everything because I didn't change prototypes

What still needs done:

  • Substations for HV to MV
  • APCs creating connection between MV and LV wires rather than its current automatic wireless connection to every device
  • LV wires connecting at range to devices through smaller "auto wires" that are raycasted
  • Changing tons of devices prototypes to make sense with these changes
  • Probably more

@PJB3005 PJB3005 added the Issue: Feature Request This issue is a feature request. label Feb 16, 2020
@ghost
Copy link
Author

ghost commented Feb 16, 2020

I think travis is failing because I fucked up the map somehow? not sure

@SweptWasTaken SweptWasTaken added Status: DO NOT MERGE DNM Status: Help Wanted Others can offer their help to this PR. labels Feb 23, 2020
@collinlunn collinlunn mentioned this pull request Apr 27, 2020
6 tasks
@Zumorica
Copy link
Contributor

Closing this in favor of #863

@Zumorica Zumorica closed this May 11, 2020
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Dec 5, 2022
- add: Added new machines and books.
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Dec 18, 2023
* smuggling admin logs and report change

* cleanup

* comments

* one more detail for admins
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Dec 18, 2023
DrSmugleaf pushed a commit to DrSmugleaf/space-station-14 that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request This issue is a feature request. Status: DO NOT MERGE DNM Status: Help Wanted Others can offer their help to this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants