fix: fixed drawer not showing anymore when tapping on fab - #746
Merged
Merged
Conversation
I tried to take a look about issue spacecowboy#662 because it's super annoying after it has been working that it's not anymore. Since there was only one commit between 2.10.0 (not working) and 2.9.2 (working) only one commit has been made. (spacecowboy#647 feat: added a search function) I tried to look at what has been done and found that searchBarVisible and repository.search has been added as params 23 and 24 offsetting other ones to 2. Later on isOpenDrawerOnFab is set incorrectly with param 26 instead of 27. My PR correct it but I don't know it there is other changes to do. Please be indulgent with my PR and let me know if it's not ok how I should have done it. I am not a real developer, don't know kotlin / java and I have no environment for it. I edited directly the file on github. :-/ Fix spacecowboy#662
Contributor
Author
|
As a side not it's also why it was still working when syncing. Param 26 is about wether syncing is currently happening. |
spacecowboy
changed the title
Owner
|
Thanks a lot @Matth7878 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to take a look about issue #662 because it's super annoying after it has been working that it's not anymore.
Between 2.10.0 (not working) and 2.9.2 (working) only one commit has been made. (#647 feat: added a search function) I tried to look at what has been done and found that searchBarVisible and repository.search has been added as params 23 and 24 offsetting other ones by 2.
Later on isOpenDrawerOnFab is set incorrectly with param 26 instead of 27. My PR correct it but I don't know if there is other changes to do. Please be indulgent with my PR and let me know if it's not ok how I should have done it. I am not a real developer, don't know kotlin / java and I have no environment for it. I edited directly the file on github and didn't have a build to test the fix. :-/
Fix #662