Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dong] support custom auth via command line #89

Merged
merged 3 commits into from Apr 13, 2020
Merged

[Dong] support custom auth via command line #89

merged 3 commits into from Apr 13, 2020

Conversation

wanaright10
Copy link
Contributor

Add command line input port & auth username and password

@spacemeowx2
Copy link
Owner

Thanks for the pr! but I don't think it's a good way to prompt user default in server side program. think about docker users.

Maybe a flag --simple-auth with its value username:password would be better

@wanaright10
Copy link
Contributor Author

@spacemeowx2 as your wishes, done.

@spacemeowx2 spacemeowx2 merged commit a2f541b into spacemeowx2:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wanaright10 @spacemeowx2