New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: changed sha256 package and added a benchmark. #24

Merged
merged 3 commits into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@facundomedica
Copy link
Contributor

facundomedica commented Dec 15, 2018

The benchmarks should use different amounts of data because the algorithms doesn't perform the same way (at least on the numbers it throws).

(ref: #23)

@avive

This comment has been minimized.

Copy link
Member

avive commented Dec 18, 2018

Good job! Let's finalize this PR:

  1. Please add to the code the c file used to generate the go assembler and a script file showing how to generate it from the source.
  2. Open a PR from your local fork of sha256-simd to this repo: https://github.com/spacemeshos/sha256-simd - so we can merge it to there, and use that lib in this project.

facundomedica added some commits Dec 18, 2018

Use spacemeshos' sha256-simd
 instead of facundomedica's
Use spacemeshos' sha256-simd
 instead of facundomedica's

@avive avive merged commit 88026db into spacemeshos:master Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment