Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atx to block #126

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Add atx to block #126

merged 3 commits into from
Dec 10, 2020

Conversation

avive
Copy link
Contributor

@avive avive commented Dec 7, 2020

No description provided.

@avive avive requested a review from lrettig December 7, 2020 14:00
@avive
Copy link
Contributor Author

avive commented Dec 7, 2020

The checks fail because I renamed a field which didn't use underscores between parts...

Copy link
Member

@lrettig lrettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one comment

@@ -44,7 +44,7 @@ message LayerDurationResponse {
message MaxTransactionsPerSecondRequest {}

message MaxTransactionsPerSecondResponse {
SimpleInt maxtxpersecond = 1;
SimpleInt max_txs_per_second = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not make superficial breaking changes like this, since it requires updating all downstream code...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now than later... we just broke our own name convention here with naming this member. right?

@avive avive merged commit 1052499 into master Dec 10, 2020
@fasmat fasmat deleted the add-atx-to-block branch December 14, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants