New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dynamic subscription #42

Merged
merged 18 commits into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@mosheka
Collaborator

mosheka commented Oct 18, 2018

Support multiple subscriptions to support multi agents and pass them to agent using env variable instead of config

  1. Support in cleaner
  2. Support in CI
  3. Support in Agent

@mosheka mosheka requested a review from gavraz Oct 18, 2018

print(cmd)
result = shell.spawn(cmd.split(' '))
print('Agent started')
except Exception as e:
print('Node/Agent started failed')
print(e.__doc__ )
self.agents += 1

This comment has been minimized.

@gavraz

gavraz Oct 18, 2018

Collaborator

Should be part of the try?
If the agent/node initiation fails you count it anyway...

This comment has been minimized.

@mosheka

mosheka Oct 24, 2018

Collaborator

I cannot know when it failed, before or after. so it's safer to keep count

t.cleanup(t.subscriber_downstream, t.subscription_path_downstream)
subscription_name_downstream = config.CONFIG['subscription_name_downstream']
for i in range [0:10]:

This comment has been minimized.

@gavraz

gavraz Oct 18, 2018

Collaborator

Remember to fix it later with a more generic approach.

@mosheka mosheka merged commit 854aed8 into master Oct 24, 2018

@mosheka mosheka deleted the get_dynamic_subscription branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment