-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Review #35
Comments
This is marked as fixed but I still see
|
I still see the UTC time in the epochs screen and not the data, per this item (marked as fixed):
|
Typo in subtitle:
|
Regarding this issue:
2nd line should be date - e.g day_of_month/month/year and not time stamp. I meant Most Recent Account |
Regarding:
Most Recent Transaction |
Regarding:
Label is currently |
Regarding:
For a vault page. Subtitle is still |
@Primaveralina - making sure you saw the issues here in my comments.... |
@Motzart - did you see my comments here on some of the fixes? |
Fix |
Fix |
Fix |
We get fee from back, it is equal 0 |
fix |
@lrettig - is this an API bug or a misunderstanding between API and backends? Currently all transactions show 0 fee. How can we address this? |
In the 119 explorer - I still see UTC formatted time in epoch screen, layer screen, tx screen, rewards screen. All dates should be displayed in user's (browser) local time. |
Which endpoint is being used to read this? Tx returned by TransactionService/MeshService does not include a "fee" field because there is no "fee" data stored on mesh. On mesh, we store the gas offered by a tx, which includes max gas ( To see gas actually used/fee paid, you'd have to look at the |
Sorry, maybe i misunderstood, but all time in app use localtime ( time from browser ), maybe problem in label 'UTC', i removed it |
@avive @lrettig so, judging from @lrettig comments we will have to wait until the necessary params are being implemented. right? |
I think that in the short-term the gas_provided smidge amount from the transaction should be displayed for simple coin transactions as this amount is always paid by the user. Longer term, this data should come from the tx receipt. |
I'm going to move any issue I see is not fixed yet to a new issue and close this mega issue. |
General comments
+
char between time and time zone code. e.g10:53:16 + UTC
->10:43:16 UTC
.few secs ago
tojust now
./epochs/566/rewards
. Needs to be fixed for all routes - see shared doc for reference of requested path syntax...Spacemesh Explorer
for all pages. For example, transactions detail page title should beTransaction Details
.0x1234...5678
for consistency.value
column is wrongly center-aligned.Start page
Transactions
and notLatest Transaction
. Subtitle:Recent transactions
./
chars in placeholder text.Browse all
link - wrong color in dark mode - please look at Figma mock - should be white...Total TXS value since genesis: 0.3 SMH
->Coin transferred: 0.3 SMHH
. We will add help tooltips with more detailed explanation to figure but we want to keep them very short for now.Transactions Page
Since Genesis
. It is obvious these are transactions. Right-most column:Value Since Genesis: 0.028 SMH
. No need to state 'total txns'.Transaction Page
Transaction Details
. Subtitle:0x1234...6789
.ago
and(
.coin
andsent
small labels in the call-out area should be aligned to the top and bottom of the text (see figma mocks).Layers Page
Age
toStarted
(to be consistent with other pages such as epochs).ATX VALUE
-> 'ATX'.[num_of_txs] [smh_value]
. e.g.10 Transactions (32.302 SMH)
.Most Recent layer\n date\n \nage
- no need for time stamp here. It is not clear what the data is without this label.Epochs Page
Total SMC
->Value
.value
column. It is too close to the rewards data column on its left.Genesis Time
. Remove detailed time-stamp and only keep date and age. e.g. 3 lines of text should be:Genesis Time\n 8/21/2020\n 9 days ago
.Epochs
->Epochs since genesis
and make the label white like in the overview screen (dark mode reviewed).Layer Page
Layer 1278
. Subtitle white:Layer details
.Finality
->Confidence
. For now there should be only 2 possible valuesConfirmed
orPending
. Confirmed is for any layer that was verified. Pending is for layers which have not been verified yet.22 blocks
->22
- it is obvious these are blocks and this is more consistent with other rows./layer/xxx
and not/layers/xxx
.Total Rewards
->Rewards
.Total Transactions
->Transactions
.TOTAL COIN REWARDS: 35.417 SMH
->Rewards 35.417 SMH
- in 2 lines.Layer Transactions Page
/layers/xxx/txs
to /layer/xxxx/txs`Layer XXX Transactions
. Subtitle: empty.Total TXNS value: 0 SMH
->Transactions Value: 0 SMH
Accounts Page
Most Recent Account \n data\n age\n
- no need for time-stamp and needs a label as it is not clear what the data is without one.--
Account Page
Coin account
(for simple coin accounts)Balance
row. Some users may miss the call-out amount.Account Transactions Page
Account Transactions
. Subtitle:0x1234...1234
(account address). The address displayed is not the account's address. See: http://stage-explore.spacemesh.io/address/0xa7A424f4A77Bfd4b72EC5a68214ac8f3Da849236/txs - looks like it is hard-coded.3 days ago
. Not sure how we missed this :-) -EPOCH Page
Epoch XXX - DETAILS
->Epoch XXX
. Sub-tile:Epoch details
.epochs/xxx
->epoch/xxx
.Epoch Number
->Number
,Total Layers
->Layers
.Total Rewards number
->Rewards
.Total Rewards value
->Rewards Amount
.EPOCH transactions page
epochs/xxx
->epoch/xxx
EPOCH layers page
epochs/xxx/layers
->epoch/xxx/layer
(see routes table in g doc spec).Search Bar
Rewards Page
All Mining Rewards
->Smeshing Rewards
. Don't use mining anywhere - just smeshing.Smesh rewards since genesis
->Rewards value since genesis
.Rewards
column label ->Reward
.Reward Page
Reward 0x1235...4567
. Subtitle: 'Details'.Layer Number
->Layer
.Smesher ID
->Smesher Id
.Smeshers Page
Committed Space
->Space
.ID
->Smesher Id
.Total ATX TXNS
->Activations
.Total Space\n [total_space]
.Smesher Page
Reward Committed
->Rewards
.Total Transactions
->Activations
.ATXs Page
Smesher 0x1345..6789 Activations
. Subtitle: empty string for now.atxns
->Activations
in right-side module.PREVATX
-> 'Previous Activation'.ATX Page
Activation 0x1234...5678
.Id
->Activation Id
.Previous ATX
->Previous Activation
.VAULT Page
Smart Wallet...
->Vault [vault_name]
. Subtitle:A vault app
.State Hash
row.Daily Spend Address
->Daily Spend Account
.Authorized Accounts
->Master Accounts
. Value for that is 1 or 3 clickable addresses.Monthly Vested Amount
and value is a SMH value.The text was updated successfully, but these errors were encountered: