Skip to content

[Merged by Bors] - Variable size PoST #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 117 commits into from
Closed

[Merged by Bors] - Variable size PoST #2039

wants to merge 117 commits into from

Conversation

noamnelke
Copy link
Member

@noamnelke noamnelke commented Jun 18, 2020 •
edited
Loading

Motivation

spacemeshos/SMIPS#6

Changes

  • Move space declaration from nipst to ATX header
  • Return weights from active set calculation
  • Use weights for block eligibility

Todo

  • Implement efficient calculation of binomial cumulative distribution function using fixed decimal point
  • Implement weighted hare eligibility using the binomial CDF
  • Update documentation as needed

Test Plan

  • Add unit tests
  • Add system test for network with heterogeneously weighted miners

@noamnelke noamnelke added this to the TN2 milestone Jun 18, 2020
@noamnelke noamnelke self-assigned this Jun 18, 2020
@noamnelke
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 9, 2020
@bors
Try #2039:
540e178
@bors
Copy link

bors bot commented Aug 9, 2020

try

Build failed:

@noamnelke
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2020
@bors
Try #2039:
2ce2c53
@bors
Copy link

bors bot commented Aug 10, 2020

try

Build failed:

@noamnelke
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2020
@bors
Try #2039:
674e50f
@bors
Copy link

bors bot commented Aug 10, 2020

try

Build failed:

@noamnelke
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2020
@bors
Try #2039:
49122bd
@bors
Copy link

bors bot commented Aug 10, 2020

try

Build failed:

bors bot added a commit that referenced this pull request May 25, 2021
@bors
Try #2039:
4a876f9
@bors
Copy link

bors bot commented May 25, 2021

try

Build failed:

@antonlerner
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 26, 2021
@bors
Try #2039:
89f8c4b
@bors
Copy link

bors bot commented May 26, 2021

try

Build succeeded:

noamnelke
noamnelke commented May 26, 2021
View reviewed changes
layerfetcher/layers.go Outdated
Comment on lines 274 to 276
l.log.Error("got")
l.layerHashResM.Lock()
l.log.Error("got here")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this should be cleaned up @antonlerner

@antonlerner
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 26, 2021
@bors
Try #2039:
1c2dfea
@bors
Copy link

bors bot commented May 26, 2021

try

Build failed:

@antonlerner
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 26, 2021
@bors
Try #2039:
c2df51d
@bors
Copy link

bors bot commented May 26, 2021

try

Build failed:

@antonlerner
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 26, 2021
@bors
Try #2039:
4dbc4da
@bors
Copy link

bors bot commented May 26, 2021

try

Build succeeded:

@noamnelke
Copy link
Member Author

bors merge

@bors
Copy link

bors bot commented May 27, 2021

👎 Rejected by too few approved reviews

@noamnelke
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request May 27, 2021
@noamnelke
Variable size PoST (#2039)
f87109c 
## Motivation
spacemeshos/SMIPS#6

## Changes
- Move space declaration from nipst to ATX header
- Return weights from active set calculation
- Use weights for block eligibility

## Todo
- [x] Implement efficient calculation of binomial cumulative distribution function using fixed decimal point
- [x] Implement weighted hare eligibility using the binomial CDF
- [ ] Update documentation as needed

## Test Plan
- [ ] Add unit tests
- [ ] Add system test for network with heterogeneously weighted miners
@bors
Copy link

bors bot commented May 27, 2021

Pull request successfully merged into develop.

Build succeeded:

@bors bors bot changed the title Variable size PoST [Merged by Bors] - Variable size PoST May 27, 2021
@bors bors bot closed this May 27, 2021
@bors bors bot deleted the var_post branch May 27, 2021 14:11
countvonzero pushed a commit that referenced this pull request May 28, 2021
@noamnelke
Variable size PoST (#2039)
ea1d42a 
## Motivation
spacemeshos/SMIPS#6

## Changes
- Move space declaration from nipst to ATX header
- Return weights from active set calculation
- Use weights for block eligibility

## Todo
- [x] Implement efficient calculation of binomial cumulative distribution function using fixed decimal point
- [x] Implement weighted hare eligibility using the binomial CDF
- [ ] Update documentation as needed

## Test Plan
- [ ] Add unit tests
- [ ] Add system test for network with heterogeneously weighted miners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshababo moshababo moshababo left review comments

@antonlerner antonlerner antonlerner approved these changes

@y0sher y0sher Awaiting requested review from y0sher

Assignees

@noamnelke noamnelke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noamnelke @lrettig @antonlerner @moshababo @sudachen