[Merged by Bors] - API phase 9: finish implementing grpc services #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
reviewed
Jul 19, 2020
antonlerner
suggested changes
Jul 19, 2020
lrettig
force-pushed
the
api-phase9
branch
3 times, most recently
from
06c9db3
to
da4c6eb
Compare
lrettig
force-pushed
the
api-phase9
branch
2 times, most recently
from
97aa29f
to
22ec8b0
Compare
Pass layersPerEpoch into the MeshService
@lrettig - looks like you are getting travis status via bors now again.... |
|
bors try |
|
bors try- |
|
bors try |
tryBuild succeeded: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
This was referenced Sep 10, 2020
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 10, 2020
## Motivation See #1764 Also Fixes #2116 Requires #2092, merge that first ## Changes - Adds stubs for all remaining services and endpoints - Upgrades to latest API build, renames a few API data items to be consistent with improved naming in the API code - Allows MeshService to read and return layer root hash: makes TransactionProcessor GetLayerStateRoot method public - Adds a config param (internal, only for testing) to force the syncer to always enable listening to gossip - Event Reporter no longer reports any details about Status updates, it just "pings" the listener which is responsible for re-fetching all status items they care about - Adds account, reward, receipt channels to Reporter; allows Reporter to block, or to increase channel buffer sizes, on initialization - Allows Reporter report methods to block (useful for tests) - Implements all endpoints that can be implemented (some, e.g. those involving transaction receipt, cannot yet be implemented) - Adds a method `GetSmesherID` to ATX to allow the nodeID that created it to be read, as part of finding ATXs by smesher for the API ## Test Plan - Adds tests for all new endpoints and services
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #1764
Also Fixes #2116
Requires #2092, merge that first
Changes
GetSmesherIDto ATX to allow the nodeID that created it to be read, as part of finding ATXs by smesher for the APITest Plan