[Merged by Bors] - Fix go version check script for MacOS. #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded: |
|
I upgraded to go 1.15 and now I'm having the same problem ^_^ I simplified and cleaned this up a bit, @divan could you please check if it still works well for you? If so I think we're ready to merge |
lrettig
approved these changes
Sep 1, 2020
|
bors try |
tryBuild failed: |
|
bors try
… |
tryBuild succeeded: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 10, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 10, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge
… |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 13, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 14, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 17, 2020
## Motivation This script offers a fix for #2097. MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore. Closes #2097 ## Changes Script `./scripts/check-go-version.sh` is modified for not using `sed`. ## Test Plan Tested on Linux and MacOS X by running script manually, and changing minimum minor version value. Co-authored-by: Lane Rettig <lanerettig@gmail.com>
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This script offers a fix for #2097.
MacOS's
sedbehaves differently from GNUsed, so the script fails to parsego versionoutput on MacOS. This solution rewritesgo versionparsing part with bash-only features, so sed is not used anymore.Closes #2097
Changes
Script
./scripts/check-go-version.shis modified for not usingsed.Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.