Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix go version check script for MacOS. #2098

Closed
wants to merge 5 commits into from

Conversation

divan
Copy link
Contributor

@divan divan commented Aug 1, 2020

Motivation

This script offers a fix for #2097.

MacOS's sed behaves differently from GNU sed, so the script fails to parse go version output on MacOS. This solution rewrites go version parsing part with bash-only features, so sed is not used anymore.

Closes #2097

Changes

Script ./scripts/check-go-version.sh is modified for not using sed.

Test Plan

Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

y0sher
y0sher approved these changes Aug 5, 2020
Copy link
Contributor

@y0sher y0sher left a comment

LGTM!

@y0sher
Copy link
Contributor

y0sher commented Aug 5, 2020

though waiting to see what you and @lrettig conclude on in #2097 before merging.

@lrettig
Copy link
Member

lrettig commented Aug 13, 2020

bors try

bors bot added a commit that referenced this pull request Aug 13, 2020
@bors
Copy link

bors bot commented Aug 13, 2020

try

Build succeeded:

@lrettig
Copy link
Member

lrettig commented Sep 1, 2020

I upgraded to go 1.15 and now I'm having the same problem ^_^

I simplified and cleaned this up a bit, @divan could you please check if it still works well for you? If so I think we're ready to merge

@lrettig lrettig self-requested a review Sep 1, 2020
lrettig
lrettig approved these changes Sep 1, 2020
@lrettig
Copy link
Member

lrettig commented Sep 3, 2020

bors try

bors bot added a commit that referenced this pull request Sep 3, 2020
@bors
Copy link

bors bot commented Sep 3, 2020

try

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 3, 2020

bors bot added a commit that referenced this pull request Sep 3, 2020
@bors
Copy link

bors bot commented Sep 3, 2020

try

Build succeeded:

@lrettig
Copy link
Member

lrettig commented Sep 10, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 10, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 10, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 10, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 10, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 10, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 12, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 12, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 12, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 12, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 12, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 12, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 12, 2020

bors bot pushed a commit that referenced this pull request Sep 12, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 12, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 13, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 13, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 14, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 14, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 14, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 14, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 16, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 16, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 16, 2020

Build failed:

@lrettig
Copy link
Member

lrettig commented Sep 17, 2020

bors merge

bors bot pushed a commit that referenced this pull request Sep 17, 2020
## Motivation
This script offers a fix for #2097.

MacOS's `sed` behaves differently from GNU `sed`, so the script fails to parse `go version` output on MacOS. This solution rewrites `go version` parsing part with bash-only features, so sed is not used anymore.

Closes #2097

## Changes
Script `./scripts/check-go-version.sh` is modified for not using `sed`.

## Test Plan
Tested on Linux and MacOS X by running script manually, and changing minimum minor version value.

Co-authored-by: Lane Rettig <lanerettig@gmail.com>
@bors
Copy link

bors bot commented Sep 17, 2020

Pull request successfully merged into develop.

Build succeeded:

@bors bors bot changed the title Fix go version check script for MacOS. [Merged by Bors] - Fix go version check script for MacOS. Sep 17, 2020
@bors bors bot closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go version check script fails on MacOS X
3 participants