Skip to content

Fix flaky blocks-add-node test #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Conversation

nkryuchkov
Copy link
Contributor

Motivation

Closes #2222

Changes

  • Fix flaky blocks-add-node test

Test Plan

  • System tests

TODO

  • Fix flaky blocks-add-node test
  • Finish created todo's
  • Document changes

@noamnelke
Copy link
Member

noamnelke commented Dec 29, 2020

@nkryuchkov I saw you reformatted a few files - I'm generally not against this, but at this point in time it may cause avoidable conflicts with other PRs, so I suggest reverting those changes and possibly making them in a separate PR after we've mostly emptied our PR queue.

Only the following files should be part of this PR:

tests/block_atx/add_node/test_blocks_add_node.py
tests/queries.py
tests/utils.py

@nkryuchkov
Copy link
Contributor Author

@noamnelke Thanks, I agree.

@nkryuchkov
Copy link
Contributor Author

Superseded by #2239

@nkryuchkov nkryuchkov closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky blocks-add-node and other tests
2 participants