-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Weak coin for self healing #2393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
lrettig
added a commit
that referenced
this pull request
May 2, 2021
- Mostly finished self-healing core logic in tortoise - Remove lots of unused code from block builder - Adds weak coin stub to hare while waiting for #2393 to be merged
Push data into the mesh rather than pulling it from hare, to better suit our architecture
Includes some more minor cleanup
lrettig
commented
May 6, 2021
bors bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 21, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 21, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 21, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 21, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation See spacemeshos/SMIPS#46 Requires #2394, #2393, #2357 Closes #2203 Closes #2687 ## Changes - adds zdist param: whereas hdist is the "Hare lookback" distance (the number of layers for which we consider hare results/local input vector rather than global opinion), zdist is the "Hare result wait" distance (the number of layers we're willing to wait for Hare to finish before reverting to invalidating layers with no input vector) - Hare explicitly reports failed CPs to the mesh, with the results stored in memory ## Test Plan TBD ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Finish rescoring block goodness after healing - [x] Rescoring block unit test - [x] Block voting weight unit test - [x] Make sure healing -> verifying tortoise handoff is working - [x] App test (for decay in active set size) - [x] Split-then-rejoin test (two way split, three way split w/o majority fork) - [x] Late blocks unit test(s) - [x] Correctly weight votes from blocks with late atxs/those with a bad beacon value (will follow up in separate issue: #2540) - [x] Multi tortoise unit tests ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [ ] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1857
Changes
Test Plan
TODO
DevOps Notes