New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract env setup to a script #305

Merged
merged 9 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@noamnelke
Copy link
Contributor

noamnelke commented Dec 4, 2018

Also, support different operating systems and architectures when installing protobuf.

@noamnelke noamnelke force-pushed the extract_env_setup branch from 0164abb to 487d0e7 Dec 4, 2018

#!/bin/bash
./ci/install-protobuf.sh

go get -u github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway

This comment has been minimized.

@antonlerner

antonlerner Dec 4, 2018

Collaborator

you are accessing github.com a lot, i'd put it in a pramaeter $GITHUB

This comment has been minimized.

@noamnelke

noamnelke Dec 4, 2018

Contributor

I think the readability and code complexity tradeoff isn't worth the DRY-ness

# Make sure you grab the latest version
curl -OL https://github.com/protocolbuffers/protobuf/releases/download/v3.6.1/protoc-3.6.1-linux-x86_64.zip
echo "fetching ${protoc_url}"
curl -L -o "protoc.zip" ${protoc_url}

This comment has been minimized.

@antonlerner

antonlerner Dec 4, 2018

Collaborator

what if this fails? maybe put in && or $? && cmd

This comment has been minimized.

@noamnelke

noamnelke Dec 4, 2018

Contributor

solved in 597e6a8

extract env setup to a script
Also, support different operating systems and architectures when installing protobuf.

@noamnelke noamnelke force-pushed the extract_env_setup branch from 487d0e7 to a23484d Dec 4, 2018

sudo mv protoc3/bin/* /usr/local/bin/

# Move protoc3/include to /usr/local/include/
sudo mv protoc3/include/* /usr/local/include/
echo "syncing include to /usr/local/include"
sudo rsync -a protoc3/include/ /usr/local/include/

This comment has been minimized.

@antonlerner

antonlerner Dec 4, 2018

Collaborator

remove sudo

@noamnelke noamnelke force-pushed the extract_env_setup branch 2 times, most recently from 1c02f0c to 51407bf Dec 4, 2018

@noamnelke noamnelke force-pushed the extract_env_setup branch from 51407bf to 9b741c4 Dec 4, 2018

@antonlerner antonlerner merged commit 90e5a88 into develop Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noamnelke noamnelke deleted the extract_env_setup branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment