Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - TXSelection: create conservative state to manage state, mempool, and TXs #3122

Closed
wants to merge 10 commits into from

Conversation

countvonzero
Copy link
Contributor

Motivation

1st PR of #3094

Changes

this PR is a no-op. behavior should remain the same before and after the change. the main idea is to create a conservative state and have it manage state, mempool and TX life cycle.

  • rename and move everything TX/mempool related to be in pkg txs
  • move TX handler out of svm pkg
  • move state and TX logic out of mesh and into conservative state

Test Plan

unit tests, system tests

TODO

  • Investigate some tests failure in conservative_test.go

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@countvonzero
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Feb 14, 2022
@bors
Copy link

bors bot commented Feb 14, 2022

try

Build succeeded:

@countvonzero
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Feb 15, 2022
@bors
Copy link

bors bot commented Feb 15, 2022

try

Build succeeded:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 15, 2022
…TXs (#3122)

## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
1st PR of #3094
<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
this PR is a no-op. behavior should remain the same before and after the change. the main idea is to create a conservative state and have it manage state, mempool and TX life cycle.

- rename and move everything TX/mempool related to be in pkg txs
- move TX handler out of svm pkg
- move state and TX logic out of mesh and into conservative state

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->
unit tests, system tests
## TODO
<!-- This section should be removed when all items are complete -->
- [ ] Investigate some tests failure in conservative_test.go

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Feb 15, 2022

Pull request successfully merged into develop.

Build succeeded:

@bors bors bot changed the title TXSelection: create conservative state to manage state, mempool, and TXs [Merged by Bors] - TXSelection: create conservative state to manage state, mempool, and TXs Feb 15, 2022
@bors bors bot closed this Feb 15, 2022
@bors bors bot deleted the tx-needs-love-too branch February 15, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants