-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - TXSelection: create conservative state to manage state, mempool, and TXs #3122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors try |
tryBuild succeeded: |
dshulyak
approved these changes
Feb 14, 2022
countvonzero
force-pushed
the
tx-needs-love-too
branch
from
February 15, 2022 00:50
e7cb199
to
9dcbe72
Compare
bors try |
tryBuild succeeded: |
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
…TXs (#3122) ## Motivation <!-- Please mention the issue fixed by this PR or detailed motivation --> 1st PR of #3094 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> ## Changes <!-- Please describe in detail the changes made --> this PR is a no-op. behavior should remain the same before and after the change. the main idea is to create a conservative state and have it manage state, mempool and TX life cycle. - rename and move everything TX/mempool related to be in pkg txs - move TX handler out of svm pkg - move state and TX logic out of mesh and into conservative state ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> unit tests, system tests ## TODO <!-- This section should be removed when all items are complete --> - [ ] Investigate some tests failure in conservative_test.go ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
TXSelection: create conservative state to manage state, mempool, and TXs
[Merged by Bors] - TXSelection: create conservative state to manage state, mempool, and TXs
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
1st PR of #3094
Changes
this PR is a no-op. behavior should remain the same before and after the change. the main idea is to create a conservative state and have it manage state, mempool and TX life cycle.
Test Plan
unit tests, system tests
TODO
DevOps Notes