[Merged by Bors] - Add CLI tool to generate an identity file #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
requested changes
Apr 11, 2022
orgr
commented
Apr 13, 2022
| @@ -84,6 +84,7 @@ COPY . . | |||
| # And compile the project | |||
There was a problem hiding this comment.
btw, docker build fails on the curl line 57 unless I add the -k flag (ignore certificates), but also I've been working from a WSL on a Windows machine so it could be a local issue.
There was a problem hiding this comment.
definitely something local, it works on the rest of prs and other dev environments
dshulyak
reviewed
Apr 20, 2022
| @@ -84,6 +84,7 @@ COPY . . | |||
| # And compile the project | |||
There was a problem hiding this comment.
definitely something local, it works on the rest of prs and other dev environments
| hare p2p: get-libs | ||
| cd cmd/$@ ; go build -o $(BIN_DIR)go-$@$(EXE) $(GOTAGS) . | ||
| cd $@ ; go build -o $(BIN_DIR)go-$@$(EXE) $(GOTAGS) . |
There was a problem hiding this comment.
this actually needs to be removed, i forgot about it
|
bors try |
tryBuild failed: |
…and remove redundant Makefile dependency
|
🔒 Permission denied Existing reviewers: click here to make orgr a reviewer |
|
@dshulyak, I've fixed the comments, linter should pass now |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
dshulyak
approved these changes
Apr 27, 2022
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
## Motivation Closes #3157 ## Changes Change the ensureIdentity to public EnsureIdentity, Add a CLI tool that calls EnsureIdentity ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed: |
|
new test is somewhat flaky. i will take a look |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
## Motivation Closes #3157 ## Changes Change the ensureIdentity to public EnsureIdentity, Add a CLI tool that calls EnsureIdentity ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
## Motivation Closes #3157 ## Changes Change the ensureIdentity to public EnsureIdentity, Add a CLI tool that calls EnsureIdentity ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3157
Changes
Change the ensureIdentity to public EnsureIdentity,
Add a CLI tool that calls EnsureIdentity
DevOps Notes