[Merged by Bors] - Add CLI tool to generate an identity file#3167
Conversation
dshulyak
left a comment
dshulyak
left a comment
There was a problem hiding this comment.
additionally we need to package it somehow. probably add it to the spacemesh docker image for simplicity
| @@ -84,6 +84,7 @@ COPY . . | |||
| # And compile the project | |||
There was a problem hiding this comment.
btw, docker build fails on the curl line 57 unless I add the -k flag (ignore certificates), but also I've been working from a WSL on a Windows machine so it could be a local issue.
There was a problem hiding this comment.
definitely something local, it works on the rest of prs and other dev environments
dshulyak
left a comment
dshulyak
left a comment
There was a problem hiding this comment.
i wonder what would be a better name for the binary. maybe genp2pid or more verbose gen-p2p-identity ?
| @@ -84,6 +84,7 @@ COPY . . | |||
| # And compile the project | |||
There was a problem hiding this comment.
definitely something local, it works on the rest of prs and other dev environments
| cd $@ ; go build -o $(BIN_DIR)$@$(EXE) $(GOTAGS) . | ||
| hare p2p: get-libs | ||
| cd cmd/$@ ; go build -o $(BIN_DIR)go-$@$(EXE) $(GOTAGS) . | ||
| cd $@ ; go build -o $(BIN_DIR)go-$@$(EXE) $(GOTAGS) . |
There was a problem hiding this comment.
this actually needs to be removed, i forgot about it
|
bors try |
tryBuild failed: |
…and remove redundant Makefile dependency
|
🔒 Permission denied Existing reviewers: click here to make orgr a reviewer |
|
@dshulyak, I've fixed the comments, linter should pass now |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
|
bors merge |
## Motivation Closes #3157 ## Changes Change the ensureIdentity to public EnsureIdentity, Add a CLI tool that calls EnsureIdentity ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed: |
|
new test is somewhat flaky. i will take a look |
|
bors merge |
## Motivation Closes #3157 ## Changes Change the ensureIdentity to public EnsureIdentity, Add a CLI tool that calls EnsureIdentity ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed: |
|
bors merge |
## Motivation Closes #3157 ## Changes Change the ensureIdentity to public EnsureIdentity, Add a CLI tool that calls EnsureIdentity ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded: |
bors
Bot
changed the title
2 participants
Motivation
Closes #3157
Changes
Change the ensureIdentity to public EnsureIdentity,
Add a CLI tool that calls EnsureIdentity
DevOps Notes