Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine #327

Merged
merged 17 commits into from Dec 18, 2018
Merged

State machine #327

merged 17 commits into from Dec 18, 2018

Conversation

@antonlerner
Copy link
Member

@antonlerner antonlerner commented Dec 16, 2018

No description provided.

@antonlerner antonlerner force-pushed the state_machine branch from ff2e39d to be88525 Dec 16, 2018
@antonlerner antonlerner force-pushed the state_machine branch from be88525 to c1c38e7 Dec 16, 2018
@antonlerner antonlerner merged commit 0365c5a into develop Dec 18, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@y0sher y0sher deleted the state_machine branch Jun 25, 2019
@noamnelke

This comment has been minimized.

Copy link
Member

@noamnelke noamnelke commented on state/global_state.go in c178338 Aug 13, 2019

The comment here is incorrect. Only newobj.SetNonce(0) (capital S) sets the object to dirty.

This comment has been minimized.

Copy link
Member Author

@antonlerner antonlerner replied Aug 13, 2019

comment is incorrect, but I think that the setStateObj following this line sets it to dirty

This comment has been minimized.

Copy link
Member

@noamnelke noamnelke replied Aug 13, 2019

No, but I just noticed the line self.makeDirtyObj(newobj) was added after self.setStateObj(newobj) in a later commit. I'll remove this comment in my PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants