[Merged by Bors] - optimistic filtering: add two more conditions #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvonzero
requested review from
dshulyak,
fasmat and
poszu
as code owners
countvonzero
changed the title
dshulyak
approved these changes
Nov 11, 2022
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
## Motivation <!-- Please mention the issue fixed by this PR or detailed motivation --> Closes #3378 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> ## Changes <!-- Please describe in detail the changes made --> add two more conditions for enabling optimistic filtering for layer N - node is confidence about every layer i < N-hdist - node has hare output for every layer i such that N-hdist <= i <= N these conditions are added to miner prior to recording its mesh hash for layer N-1 in its proposal. note: this is done at proposal creation time instead of block creation time to prevent nodes from making different decisions on whether to do optimistic filtering and causing multiple blocks created for the same layer.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
## Motivation <!-- Please mention the issue fixed by this PR or detailed motivation --> Closes #3378 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> ## Changes <!-- Please describe in detail the changes made --> add two more conditions for enabling optimistic filtering for layer N - node is confidence about every layer i < N-hdist - node has hare output for every layer i such that N-hdist <= i <= N these conditions are added to miner prior to recording its mesh hash for layer N-1 in its proposal. note: this is done at proposal creation time instead of block creation time to prevent nodes from making different decisions on whether to do optimistic filtering and causing multiple blocks created for the same layer.
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3378
Changes
add two more conditions for enabling optimistic filtering for layer N
these conditions are added to miner prior to recording its mesh hash for layer N-1 in its proposal.
note: this is done at proposal creation time instead of block creation time to prevent nodes from making different decisions on whether to do optimistic filtering and causing multiple blocks created for the same layer.