[Merged by Bors] - Add automatic retries in Poet's HTTP client #4018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
reviewed
Jan 28, 2023
fasmat
approved these changes
Jan 30, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
## Motivation HTTP requests are fallible but communication node -> poet is critical. Node should retry talking with poet in case of: - ephemeral errors (5xx, 429 - too many requests) - 404 - not found. A Poet returns 404 if a node queries for proof too early (the proof is not yet ready - hence "not found"). ## Changes - use https://github.com/hashicorp/go-retryablehttp for automatic retries with a custom policy to retry on 404, - use linear backoff with small jitter (within 1 second) to prevent spamming poet with retries at the same time from all nodes. Closes #2614
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
HTTP requests are fallible but communication node -> poet is critical. Node should retry talking with poet in case of:
Changes
Closes #2614