New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hare integration testing #414

Merged
merged 15 commits into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@gavraz
Copy link
Contributor

gavraz commented Jan 9, 2019

Added unit tests (better coverage).
Added integration tests.
Includes a few fixes.

@wliyongfeng

This comment has been minimized.

Copy link

wliyongfeng commented Jan 9, 2019

I created #415 after I saw this pr. Do you still need sb to to do the work for #374 ? If not, could you close the gitcoin issue.

@zalmen

zalmen approved these changes Jan 9, 2019

return false
}

if m.Message.Values == nil {

This comment has been minimized.

@zalmen

zalmen Jan 9, 2019

Member

consider checking that m.Messages.Values isn't empty

@gavraz gavraz force-pushed the hare_integration branch from 4567061 to a88c070 Jan 9, 2019

@gavraz gavraz merged commit 001cdbb into develop Jan 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment