Hare rolacle #458
Merged
Hare rolacle #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gavraz
commented
Jan 16, 2019
gavraz
commented
- Added rolacle mock for testing
- Added unit tests
- Rebased to include last changes pushed to develop
zalmen
reviewed
Jan 17, 2019
hare/mock_oracle.go
Outdated
| func NewMockHashOracle(expectedSize int, comitySize int) *MockHashOracle { | ||
| mock := new(MockHashOracle) | ||
| mock.clients = make(map[string]struct{}, expectedSize) | ||
| mock.comitySize = comitySize |
hare/mock_oracle.go
Outdated
| } | ||
|
|
||
| func (mock *MockHashOracle) calcThreshold(comitySize int) uint32 { | ||
| if len(mock.clients) == 0 { |
There was a problem hiding this comment.
you should also lock when checking for the length. Consider using RWMutex instead of Mutex
There was a problem hiding this comment.
It is good to have this check to detect bug, but you also need to check that committeeSize <= len(mock.clients)
hare/mock_oracle.go
Outdated
|
|
||
| func (mock *MockHashOracle) calcThreshold(comitySize int) uint32 { | ||
| if len(mock.clients) == 0 { | ||
| panic("Called calcThreshold with 0 clients registered") |
There was a problem hiding this comment.
No reason to panic, print a fat error message and return 0
hare/mock_oracle.go
Outdated
| data := binary.LittleEndian.Uint32(proof) | ||
| // calculate thresholds | ||
| threshLeader := mock.calcThreshold(3) // expect 3 leaders | ||
| threshActive := mock.calcThreshold(mock.comitySize) // expect comitySize-3 actives |
There was a problem hiding this comment.
don't understand the comment, why -3?
hare/mock_oracle.go
Outdated
|
|
||
| if data < 10 { | ||
| // calculate hash of proof | ||
| hash := fnv.New32() |
There was a problem hiding this comment.
you should have a struct responsible for hashing, this struct should also return the max value (instead of the maxUint32 above). This way you'll make sure that no one changes the hash type without forgetting to update the max value
zalmen
approved these changes
Jan 17, 2019
y0sher
pushed a commit
that referenced
this pull request
Jan 21, 2019
* Added mock oracle for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.