Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix dht flaky test #466
Conversation
y0sher
changed the title
removing the timeout from the test.
dix dht flaky test
Jan 21, 2019
y0sher
requested a review
from
antonlerner
Jan 21, 2019
y0sher
changed the title
dix dht flaky test
fix dht flaky test
Jan 21, 2019
zalmen
approved these changes
Jan 21, 2019
y0sher
requested a review
from
zalmen
Jan 21, 2019
y0sher
merged commit 704c53a
into
develop
Jan 21, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
y0sher
deleted the
p2p_dht_flaky_test
branch
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
y0sher commentedJan 21, 2019
•
edited
this test is slower on slower machines so we remove the timeout and relay on the channels only.