New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved installation #475

Merged
merged 4 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@noamnelke
Copy link
Contributor

noamnelke commented Jan 23, 2019

  • Check go ver is 1.11+.
  • Install deps ahead of relying on them.

This is currently bash only.

@noamnelke

This comment has been minimized.

Copy link
Contributor Author

noamnelke commented Jan 23, 2019

Fixes #440

@noamnelke noamnelke requested review from antonlerner and zalmen Jan 23, 2019

@noamnelke

This comment has been minimized.

Copy link
Contributor Author

noamnelke commented Jan 23, 2019

@antonlerner this is currently bash only -- do you want to enlist the community in checking minimum go version on Windows?

@antonlerner

This comment has been minimized.

Copy link
Collaborator

antonlerner commented Jan 23, 2019

If it's not a big deal, I'd rather we solve this internally, we had some dev's struggling with this one.
Also, and regardless, we need to check that this script runs on linux (ubuntu) and mac as well - this is the most important goal of all these fixes - to allow our users to setup our env easily.

@noamnelke

This comment has been minimized.

Copy link
Contributor Author

noamnelke commented Jan 23, 2019

@antonlerner The installation works on Mac (tested locally) and on Ubuntu (tested on Travis).

It's supposed to fail fast with an old version of Go and I've tested this on Travis.

Making the Go version check work on Windows is not trivial. I've used sed to parse the version string, and bash scripting to compare to the expected minimum version. I have no experience with Windows batch file programming and no Windows machine to test on here. I can learn some Windows scripting and test tomorrow in the office, or install a Windows VM, but this is a non-critical, nice to have, part of the installation that should just help with debugging (help developers understand that they have a version of Go that's too old). Implementing it for Windows seems not worth the effort to me.

@zalmen - wdyt?

Show resolved Hide resolved setup_env.sh Outdated
@noamnelke

This comment has been minimized.

Copy link
Contributor Author

noamnelke commented Jan 24, 2019

@antonlerner I've added Windows support. I'm relying on PowerShell, which is installed by default since Windows 7.

@noamnelke noamnelke merged commit 41290c1 into develop Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noamnelke noamnelke deleted the improved_installation branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment